Conversation
Member
|
Can we add a test/example for this specifically? |
Contributor
Author
|
This is actually a bit worse than I thought. The space above and below will be ignored 99.6% (255/256, the chance that the lower byte of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bool fontlib_SetFont(const fontlib_font_t *font_data, fontlib_load_options_t flags);It looks like this code reads from
font_datainstead offlags. since the low byte offont_datawill be non-zero 255/256 times, then I would assume that line spacing will almost always be treated as ignored