fix(tpu): fix LoRA and V1 engine crashes#1
Draft
chiajunglien wants to merge 3 commits intoCIeNET-International:mainfrom
Draft
fix(tpu): fix LoRA and V1 engine crashes#1chiajunglien wants to merge 3 commits intoCIeNET-International:mainfrom
chiajunglien wants to merge 3 commits intoCIeNET-International:mainfrom
Conversation
6638a66 to
0246048
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes
utils.py): Added support fornn.ParameterListin_get_lora_device. This prevents AttributeError when weights are stored in containers, which is common in TPU and MoE implementations.The following command was used to verify the fixes on TPU v6e:
MODEL_IMPL_TYPE=vllm TPU_BACKEND_TYPE=jax python3 examples/offline_inference/multilora_inference.pyPurpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://docs.vllm.ai/en/latest/contributing (anything written below this line will be removed by GitHub Actions)