Skip to content

fix(tpu): fix LoRA and V1 engine crashes#1

Draft
chiajunglien wants to merge 3 commits intoCIeNET-International:mainfrom
chiajunglien:emmalien/fix-tpu-lora-v1
Draft

fix(tpu): fix LoRA and V1 engine crashes#1
chiajunglien wants to merge 3 commits intoCIeNET-International:mainfrom
chiajunglien:emmalien/fix-tpu-lora-v1

Conversation

@chiajunglien
Copy link
Copy Markdown

@chiajunglien chiajunglien commented Mar 30, 2026

Key Changes

  • Fixed LoRA Device Retrieval (utils.py): Added support for nn.ParameterList in _get_lora_device. This prevents AttributeError when weights are stored in containers, which is common in TPU and MoE implementations.

The following command was used to verify the fixes on TPU v6e:
MODEL_IMPL_TYPE=vllm TPU_BACKEND_TYPE=jax python3 examples/offline_inference/multilora_inference.py

Purpose

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

BEFORE SUBMITTING, PLEASE READ https://docs.vllm.ai/en/latest/contributing (anything written below this line will be removed by GitHub Actions)

@chiajunglien chiajunglien changed the title fix(tpu): fix LoRA crashes, engine interface mismatch, and loader sta… fix(tpu): fix LoRA and V1 engine crashes Mar 30, 2026
@chiajunglien chiajunglien force-pushed the emmalien/fix-tpu-lora-v1 branch from 6638a66 to 0246048 Compare April 13, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant