Skip to content

fix: return carriage handling#83

Merged
Mayday-01 merged 1 commit intomainfrom
fix/newline-uart-cmdhandler
Mar 3, 2026
Merged

fix: return carriage handling#83
Mayday-01 merged 1 commit intomainfrom
fix/newline-uart-cmdhandler

Conversation

@Elan456
Copy link
Contributor

@Elan456 Elan456 commented Mar 3, 2026

Description

Summary of Changes

  • Properly utilizes the \r ignore by checking for a \r followed by a \n

Motivation

  • Eliminates an issue on some terminal where you have to press enter twice.

Testing

Check all that apply:

  • I have added or modified tests to cover these changes.
  • I have manually tested the changes on the target device(s) or environment(s).
  • Existing tests were reviewed to ensure they still work as expected.
  • If tests were not added or modified, explain why:

    (Provide reasoning here)


Building

  • This change successfully builds in at least one of the following environments:
    • Native repo
    • Target device(s) (e.g., MARTHA)
  • If the build fails in any environment, explain why:

    (Provide reasoning here)


Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code where necessary for clarity.
  • I have made corresponding updates to documentation (if applicable).

@Elan456 Elan456 requested a review from Mayday-01 March 3, 2026 22:36
Copy link
Contributor

@Mayday-01 Mayday-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Mayday-01 Mayday-01 merged commit 1a4fbc5 into main Mar 3, 2026
2 checks passed
@Elan456 Elan456 deleted the fix/newline-uart-cmdhandler branch March 12, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants