Open
Conversation
Member
|
Hey. This is a question of debate if to use cursor pointer or not on buttons. At the moment it uses default from tailwindcss, which disabled it. Can see shadcn-ui/ui#6843 and tailwindlabs/tailwindcss#15203 for additional info. |
Author
|
Seems like a very controversial change |
Member
|
Yeah it is. I don't have a strong opinion about this. My understanding is that the button doesn't need a pointer because it won't change location to another page. While links (even looking as buttons) show a pointer to indicate location change. If you wish to add this, then please follow the https://tailwindcss.com/docs/upgrade-guide#buttons-use-the-default-cursor way, since it should be a uniform way set in a single place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some polishes for some buttons missing the interact feel