-
Notifications
You must be signed in to change notification settings - Fork 5
Add Signal Handling, Cacti process registration, and php-cs-fixer #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request implements signal handling, Cacti process registration with algorithmic timeouts, and applies PSR formatting standards to the servcheck plugin code.
Changes:
- Adds signal handlers (SIGTERM, SIGINT, SIGUSR1) to gracefully shut down child processes
- Implements Cacti process control with calculated timeouts based on test parameters
- Adds shebang lines to poller_servcheck.php and servcheck_process.php
- Converts array syntax from
array()to[](PSR-12 standard) - Removes obsolete plugin_servcheck_processes table
- Adds configurable concurrent process count setting
Reviewed changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| poller_servcheck.php | Adds signal handlers, process registration/management, and concurrent process control |
| servcheck_process.php | Adds signal handlers, process registration with timeout calculation, and performance statistics |
| setup.php | Removes obsolete processes table, adds concurrent processes setting, applies PSR formatting |
| servcheck_test.php | PSR formatting changes (array syntax, spacing, comments) |
| servcheck_*.php | PSR formatting changes across multiple files |
| includes/test_*.php | PSR formatting changes in test modules |
| includes/functions.php | PSR formatting and minor improvements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 22 out of 23 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 22 out of 23 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| AND poller_id = ? ' . | ||
| $sql_condition, | ||
| array($poller_id)); | ||
| WHERE enabled = 'on', |
Copilot
AI
Feb 4, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SQL syntax error: There's a comma after 'WHERE enabled = "on"' when it should be removed or the SQL statement is incomplete. This will cause a database query error.
This pull request does the following: