Keeping objects after workplane creation#971
Draft
Jojain wants to merge 1 commit intoCadQuery:masterfrom
Draft
Conversation
Member
|
Thanks, it might be trickier in terms of backward-compatibility than I expected. |
Member
|
I think it'd be better to add a kwarg to work plane (say |
Contributor
Author
|
Yeah that's probably easier to deal with. Do we want to reset the selection totally calling |
Member
Why not something like this: if not reset:
s.objects = self.objects[:] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep selected objects after workplane creation, it breaks quite a lof of tests, we need to investigate if the failing test can be rewritten or if it's really a breaking change
Aims to solve #149