Skip to content

CryoScope 2.0#93

Open
astronomerdave wants to merge 4 commits intocamera-2.0from
DH/camera2-cryoscope
Open

CryoScope 2.0#93
astronomerdave wants to merge 4 commits intocamera-2.0from
DH/camera2-cryoscope

Conversation

@astronomerdave
Copy link
Copy Markdown
Collaborator

This implements CryoScope as the first customer of the new camerad-2.0.

 - adds Instruments/cryoscope/ specific files
 - renames RXRV -> VIDEORXR for consistency with ACF files
 - adds Exposuremode_VIDEORXR class
 - adds producer thread for VIDEORXR
affecting all instruments:
 - adds ImageQueue class
 - adds get functions to Config class
 - camerad now initializes the logging system
@astronomerdave
Copy link
Copy Markdown
Collaborator Author

I'm starting this as a draft PR until it's finished. I've only added the producer thread. I'll add the consumer thread next.

@astronomerdave astronomerdave changed the base branch from main to camera-2.0 April 2, 2026 19:30
adds deinterlacing
adds placeholders for subtraction and fits writing
changes logwrite to accept std::string_view
@astronomerdave astronomerdave marked this pull request as ready for review April 16, 2026 18:29
@astronomerdave
Copy link
Copy Markdown
Collaborator Author

Cryoscope is not fully functional here yet, but this adds things of general interest. A brief summary follows:

  1. organizational change: moves Camera::ExposureModeRXRV (and support functions related to ExposureModeRXRV) out of archon_exposure_modes.cpp and into its own file, archon_exposure_modes_rxrv.cpp, because once we start adding code to all of the exposure modes, putting them all into the one file would make it huge.
  2. new code: adds functionality to Camera::ExposureMode_VIDEORXR::image_acquisition_thread that wasn't there before
  3. new code: passes exposure mode arguments when constructing the exposure mode object in Camera::ArchonInterface::set_exposure_mode
  4. new feature: implements a proper FIFO wrapper to the enqueue object that the producer/consumer threads use. This is in its own file, image_queue.h
  5. new feature: adds new functions to Config class to get optional and required config keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant