Feature/experiment logs tab by danoswaltCL · Pull Request #2981 · CarnegieLearningWeb/UpGrade

danoswaltCL · 2026-02-27T18:16:52Z

SO...

The main new backend functionality here is fetching audit logs by adding the optional experimentId to the existing /audit endpoint.

The main new frontend functionality (other than adding the new tab) is that when the experiment-specific logs are received, we will save these experiment-specific logs + metadata (skip, filter, take, total) in a map on the logs store by experimentId:

*** FOLLOW-UPS ***
This is an initial component to get something in there, it's intentionally left ugly, we can sculpt it as we go and make some decisions:

Updating the styling, formatting, and language of the individual log messages. This is largely ported directly over from the audit logs tab and I mostly left as-is. It is messy in there, we can do better.

NOTE: because we have a mix of standalone and non-standalone components, it was awkward to try and re-use the "pipes" that are used here, so they are basically duplicated as standalones. these too are a little messy and will need the same attention, but they will do the trick for now.

Backend should probably be doing search/filter things because this is a paginated list

Copilot

Pull request overview

This PR adds a new "Logs" tab to the experiment details page, allowing users to view audit logs specific to a particular experiment. The implementation includes both backend and frontend changes to filter audit logs by experiment ID and display them in a timeline format with search and filtering capabilities.

Changes:

Backend adds optional experimentId parameter to the audit logs API endpoint
Frontend implements experiment-specific log storage in NgRx store using a map indexed by experimentId
New standalone components for displaying experiment logs with timeline view, search, and pagination

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 18 comments.

Show a summary per file

File	Description
backend/packages/Upgrade/src/api/controllers/LogController.ts	Added experimentId parameter to audit logs endpoint documentation and implementation
backend/packages/Upgrade/src/api/controllers/validators/AuditLogParamsValidators.ts	Added validation for optional experimentId UUID parameter
backend/packages/Upgrade/src/api/services/AuditService.ts	Updated service methods to accept and pass experimentId filter
backend/packages/Upgrade/src/api/repositories/ExperimentAuditLogRepository.ts	Implemented experimentId filtering in database queries using JSON field extraction
frontend/.../logs.actions.ts	Added new actions for experiment-specific log fetching and filtering
frontend/.../logs.reducer.ts	Implemented state management for experiment logs stored by experimentId
frontend/.../logs.selectors.ts	Added selectors for accessing experiment-specific log state
frontend/.../logs.model.ts	Added ExperimentLogsMetadata interface and updated AuditLogParams
frontend/.../logs.effects.ts	Implemented effect handlers for fetching experiment-specific logs
frontend/.../logs.service.ts	Added service methods for experiment log operations
frontend/.../common-section-card-search-header/*	Enhanced search header to support grouped filter options
frontend/.../experiment-overview-details-footer/*	Added "Logs" tab to experiment details navigation
frontend/.../experiment-log-section-card/*	New component for displaying experiment logs with search and pagination
frontend/.../experiment-logs-timeline/*	New timeline component for rendering log entries
frontend/.../experiment-log-diff-display/*	New component for displaying log diffs in expandable panels
frontend/.../pipes/*	New standalone pipes for formatting log dates and messages
frontend/.../experiment-details-page-content.*	Integrated logs tab into experiment details page

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

frontend/projects/upgrade/src/app/core/logs/store/logs.effects.ts

...nt-details-page-content/experiment-log-section-card/experiment-log-section-card.component.ts

frontend/projects/upgrade/src/app/core/logs/store/logs.model.ts

...experiment-log-section-card/experiment-logs-timeline/experiment-logs-timeline.component.html

...t/experiment-log-section-card/experiment-logs-timeline/experiment-logs-timeline.component.ts

...experiment-log-section-card/experiment-logs-timeline/experiment-logs-timeline.component.html

...-details-page-content/experiment-log-section-card/experiment-log-section-card.component.html

Copilot

Pull request overview

Copilot reviewed 31 out of 33 changed files in this pull request and generated 5 comments.

Files not reviewed (1)

frontend/package-lock.json: Language not supported

Comments suppressed due to low confidence (1)

frontend/projects/upgrade/src/app/features/dashboard/logs/logs.module.ts:13

LogsModule no longer declares LogDateFormatPipe, but templates in this module still use | logDateFormatPipe (e.g. audit-logs.component.html / error-logs.component.html). Since LogDateFormatPipe is non-standalone, it must be declared in this module or exported from an imported module (e.g. SharedModule) to avoid a template compilation error.

import { SharedModule } from '../../../shared/shared.module';

import { ErrorLogsComponent } from './components/error-logs/error-logs.component';
import { AuditLogsComponent } from './components/audit-logs/audit-logs.component';
import { TimelineComponent } from './components/timeline/timeline.component';
import { ErrorLogPipe } from './pipes/error-log.pipe';
import { ExperimentActionMessage } from './pipes/experiment-action-message.pipe';
import { LogsComponent } from './root/logs.component';
import { LogsRoutingModule } from './logs-routing.module';
import { ListOperationsMessage } from './pipes/list-operation-message.pipe';

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...-details-page-content/experiment-log-section-card/experiment-log-section-card.component.html

...t/experiment-log-section-card/experiment-logs-timeline/experiment-logs-timeline.component.ts

.../components/common-section-card-search-header/common-section-card-search-header.component.ts

frontend/projects/upgrade/src/app/core/logs/logs.service.ts

backend/packages/Upgrade/src/api/repositories/ExperimentAuditLogRepository.ts

danoswaltCL · 2026-03-02T19:09:58Z

putting this into draft, i discovered i need to actually make this generalizable so that we can use this component for feature flags also (and/or segments).

zackcl · 2026-03-02T20:05:25Z

I might be missing something, but I’m seeing this error when I click the Logs tab:

app-error-handler.service.ts:18 ERROR TypeError: Cannot read properties of undefined (reading 'onDestroy')
    at da (debug_node.mjs:28156:17)
    at A1 (experiment-log-section-card.component.html:34:37)

Copilot

Pull request overview

Copilot reviewed 37 out of 39 changed files in this pull request and generated 12 comments.

Files not reviewed (1)

frontend/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...-audit-log-timeline/common-audit-log-diff-display/common-audit-log-diff-display.component.ts

...-component-lib/components/common-audit-log-timeline/common-audit-log-timeline.component.html

frontend/projects/upgrade/src/app/core/logs/store/logs.selectors.ts

backend/packages/Upgrade/src/api/services/AuditService.ts

backend/packages/Upgrade/src/api/repositories/ExperimentAuditLogRepository.ts

frontend/projects/upgrade/src/app/core/logs/store/logs.effects.ts

...nt-details-page-content/experiment-log-section-card/experiment-log-section-card.component.ts

backend/packages/Upgrade/src/api/repositories/ExperimentAuditLogRepository.ts

.../components/common-section-card-search-header/common-section-card-search-header.component.ts

frontend/projects/upgrade/src/app/core/logs/store/logs.model.ts

Copilot

Pull request overview

Copilot reviewed 37 out of 39 changed files in this pull request and generated 6 comments.

Files not reviewed (1)

frontend/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...-component-lib/components/common-audit-log-timeline/common-audit-log-timeline.component.html

.../components/common-section-card-search-header/common-section-card-search-header.component.ts

...-details-page-content/experiment-log-section-card/experiment-log-section-card.component.html

...nt-details-page-content/experiment-log-section-card/experiment-log-section-card.component.ts

...-details-page-content/experiment-log-section-card/experiment-log-section-card.component.scss

Copilot · 2026-03-03T19:23:07Z

@danoswaltCL I've opened a new pull request, #2991, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Pull request overview

Copilot reviewed 38 out of 40 changed files in this pull request and generated 4 comments.

Files not reviewed (1)

frontend/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

backend/packages/Upgrade/src/api/repositories/ExperimentAuditLogRepository.ts

backend/packages/Upgrade/src/api/services/AuditService.ts

Copilot · 2026-03-03T21:23:06Z

frontend/projects/upgrade/src/app/core/logs/store/logs.effects.ts

+  getExperimentLogs$ = createEffect(() =>
+    this.actions$.pipe(
+      ofType(logsActions.actionGetExperimentLogs),
+      withLatestFrom(this.store$.pipe(select(selectExperimentLogsState))),
+      map(([action, experimentLogsState]) => ({
+        experimentId: action.experimentId,
+        fromStart: action.fromStart || false,
+        metadata: experimentLogsState[action.experimentId],
+      })),
+      filter(({ metadata, fromStart }) => {
+        if (fromStart) return true;
+        if (!metadata || metadata.total === null) return true;
+        return metadata.skip < metadata.total;
+      }),
+      mergeMap(({ experimentId, fromStart, metadata }) => {
+        const skip = fromStart ? 0 : metadata?.skip || 0;
+        const filter = metadata?.filter || null;
+
+        let params: AuditLogParams = {
+          skip,
+          take: NUMBER_OF_LOGS,
+          experimentId,
+        };
+
+        if (filter) {
+          params = { ...params, filter };
+        }
+
+        return this.logsDataService.getAllAuditLogs(params).pipe(
+          map((data: any) =>
+            logsActions.actionGetExperimentLogsSuccess({
+              experimentId,
+              auditLogs: data.nodes,
+              totalAuditLogs: data.total,
+              fromStart,
+            })
+          ),
+          catchError(() => [logsActions.actionGetExperimentLogsFailure({ experimentId })])
+        );
+      })
+    )
+  );


New behavior was added in getExperimentLogs$ / changeExperimentLogFilter$, but there are no corresponding unit tests (the existing logs.effects.spec.ts covers other effects but has no coverage for experiment-specific logs). Add tests that verify: (1) experimentId is included in the request params, (2) pagination short-circuits when skip >= total, and (3) actionSetExperimentLogFilter triggers a refetch fromStart.

.../components/common-section-card-search-header/common-section-card-search-header.component.ts

zackcl · 2026-03-04T14:00:33Z

Do you want to resolve or ignore Copilot's comments?

danoswaltCL · 2026-03-04T14:19:35Z

Do you want to resolve or ignore Copilot's comments?

? I've been resolving and ignoring many copilot comments.

zackcl · 2026-03-04T15:59:30Z

I meant there's still one opened review comment from Copilot for this PR. It would be nice if you hide it or click "Resolve conversation" so that it's clear no more changes will be added to this PR.

danoswaltCL · 2026-03-04T16:15:45Z

the comment is about adding unit tests, which i ought to do, so i left it open, but that shouldn't keep anyone from reviewing, it's ready.

danoswaltCL added 2 commits February 19, 2026 13:09

initial logs tab and backend support for experimentId

f9f248a

refined timeline component

8b9352e

danoswaltCL requested review from bcb37, Copilot and zackcl and removed request for bcb37 February 27, 2026 18:16

Copilot started reviewing on behalf of danoswaltCL February 27, 2026 18:17 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

danoswaltCL added 2 commits February 27, 2026 17:17

remove unused code, use simple map instead of pipes

7037138

refactor timeline and pipe usage

adc2c13

danoswaltCL requested a review from Copilot March 2, 2026 17:35

Copilot started reviewing on behalf of danoswaltCL March 2, 2026 17:36 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

danoswaltCL marked this pull request as draft March 2, 2026 19:08

refactor to make timeline component generalizeable

889df12

danoswaltCL requested a review from Copilot March 3, 2026 17:37

Copilot started reviewing on behalf of danoswaltCL March 3, 2026 17:37 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

danoswaltCL force-pushed the feature/experiment-logs-tab branch 7 times, most recently from 8b85547 to 8a97756 Compare March 3, 2026 18:32

danoswaltCL requested a review from Copilot March 3, 2026 18:34

Copilot started reviewing on behalf of danoswaltCL March 3, 2026 18:35 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

danoswaltCL force-pushed the feature/experiment-logs-tab branch from 8a97756 to 925661a Compare March 3, 2026 19:06

Copilot AI mentioned this pull request Mar 3, 2026

[WIP] Update experiment logs tab feature implementation #2991

Closed

danoswaltCL force-pushed the feature/experiment-logs-tab branch 2 times, most recently from 5f24e15 to 1389054 Compare March 3, 2026 21:13

danoswaltCL marked this pull request as ready for review March 3, 2026 21:16

danoswaltCL requested a review from Copilot March 3, 2026 21:16

Copilot started reviewing on behalf of danoswaltCL March 3, 2026 21:16 View session

danoswaltCL force-pushed the feature/experiment-logs-tab branch from 1389054 to b976728 Compare March 3, 2026 21:17

Copilot AI reviewed Mar 3, 2026

View reviewed changes

refactor to make timeline component generalizeable

23e87c5

danoswaltCL force-pushed the feature/experiment-logs-tab branch from b976728 to 23e87c5 Compare March 3, 2026 22:05

Conversation

danoswaltCL commented Feb 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danoswaltCL commented Mar 2, 2026

Uh oh!

zackcl commented Mar 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zackcl commented Mar 4, 2026

Uh oh!

danoswaltCL commented Mar 4, 2026

Uh oh!

zackcl commented Mar 4, 2026

Uh oh!

danoswaltCL commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone