fix: fix arg remap bug in InsertParamAndRemapIndices for Ldarg_1/Ldarg_2

[CedaryCat]

Summary by Sourcery

Bug Fixes:

• Correct argument loading opcode remapping for Ldarg_0 through Ldarg_3 when inserting a new parameter, accounting for the implicit instance parameter in non-static methods.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts argument index remapping in InsertParamAndRemapIndices to correctly handle Ldarg_1/Ldarg_2 (and related short forms) when inserting a parameter, centralizing index calculations and fixing the Ldarg_3 remap operand.

File-Level Changes

Change	Details	Files
Centralize and correct inserted-argument slot calculations for remapping Ldarg_* opcodes when inserting a parameter into a method body.	Introduce insertedArgSlot to represent the effective argument slot of the newly inserted parameter, accounting for instance vs static methods. Introduce shiftedLdarg3ParamIndex to compute the correct parameter index used when remapping Ldarg_3 to Ldarg_S. Update Ldarg_0/Ldarg_1/Ldarg_2 remap conditions to compare against insertedArgSlot instead of raw index and static checks, ensuring correct shifting thresholds. Simplify Ldarg_3 handling by using shiftedLdarg3ParamIndex for the new Ldarg_S operand instead of duplicating static/instance branching logic.	src/OTAPI.UnifiedServerProcess/Core/Patching/PatchingCommon.cs

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}