Add a docker endpoint for health-check of archive node docker image#421
Closed
ayushmishra2005 wants to merge 1 commit intoold-devfrom
Closed
Add a docker endpoint for health-check of archive node docker image#421ayushmishra2005 wants to merge 1 commit intoold-devfrom
ayushmishra2005 wants to merge 1 commit intoold-devfrom
Conversation
yahortsaryk
requested changes
Aug 16, 2024
| set -e | ||
|
|
||
| head () { | ||
| polkadot-js-api --ws ws://127.0.0.1:9944 query.system.number 2>/dev/null |\ |
Contributor
There was a problem hiding this comment.
I don't think this endpoint performs the check for synchronization. The health check should respond with failure in case node is in syncing process at the moment to let the load balancer evict it from the pool. Please, read the doc I sent you previously. We should mimic the /health/readiness endpoint in our health check.
Contributor
Author
There was a problem hiding this comment.
Sure. Let me address this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Please select the branch type you are merging and fill in the relevant template.
Fix or Feature
Types of Changes
Migrations and Hooks
on_initializeon_finalizeChecklist for Fix or Feature
spec_versionhas been incremented.network-relayer's events have been updated according to the blockchain events if applicable.Checklist for Hotfix
spec_versionhas been incremented.devhas been created.staginghas been created.network-relayer's events have been updated according to the blockchain events if applicable.Checklist for Release