Conversation
anderslindho
left a comment
anderslindho
left a comment
There was a problem hiding this comment.
Largely looks fine, but you missed README - should maybe grep for further potential mentions of java 21 (also for elastic if you keep that upgrade). You should, however, inspect failing CI - looks like you might be missing some dep/plugin update (Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.10:report (report)); are you maybe missing an update of Maven? It is used at least for CI. If so, check also for maven wrapper, as that might need an update too.
A few nitpicks:
- 4 new sonar issues introduced, 2 of which seem to relate to the java version (it doesn't like you naming the exception
exfor some reason) - would maybe be better to do dep update before java25 update, to have each commit pass build, etc.
simon-ess
force-pushed
the
update_java
branch
2 times, most recently
from
3f3ce04 to
488e863
Compare
simon-ess
force-pushed
the
update_java
branch
from
488e863 to
d410479
Compare
We use curl to test the health of the container. This has been removed in eclipse-temurin:25-jre, so we add it back.
|
Code coverage is failing, but it looks like a docker API thing. |
|
Don't we need to update maven (wrapper)? |
|
What needs to be updated in the wrapper? I see no reference to jdk versions in there. |
|
IIRC I had to update it for CE, but don't remember why... |
|
It seems like it is not necessary, but I may as well, why not... |
|
3 participants
Updates to java 25 as well as a few other package updates, and minor update-related cleanup.