Open
Conversation
To uniquely identify a lun we need the SVM + full lun path as item name.
|
Thank you for your contribution. This pull request has been marked as stale as it has not passed the automated tests and there was no activity for the last 14 days. This pull request will be closed due to inactivity after 60 days, if no action is taken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General information
This change makes the item name of the netapp_ontap_luns check unique to make sure, that all luns are actually monitored.
Proposed changes
Prior to this change, only the last part of the LUN path was used as the item name.
Therefore, a LUN with path /vol/lun_w2k19_vol/lun_w2k19 resulted in an item name lun_w2k19.
If you have multiple LUNs ending with the same name, you would end up monitoring just one LUN .
To make things even more complex, not even the full LUN path is guaranteed to be unique.
This is, because you can have identical LUN paths, as long as they are in two different SVMs.
To summarize this.
To uniquely identify a lun we need the SVM + full lun path as item name.
iscsi_aix_test:/vol/lun_w2k19_vol/lun_w2k19
The SVM and volume details in the check summary are kind of obsolete with the change, because the service description already contains this information.
Please be aware, that you have the same issue with interfaces, and qtrees. You should consider that as well.