Merged
Conversation
nathanthorpe
approved these changes
Mar 19, 2026
| self, | ||
| name: str = None, | ||
| project_id: str = None, | ||
| datasets: list = None, |
Contributor
There was a problem hiding this comment.
can you add a type to this
Contributor
Author
There was a problem hiding this comment.
I actually had to remove that because it caused a circular import error
Contributor
There was a problem hiding this comment.
can you do 'DataPortalDataset' in single quotes?
Contributor
Author
There was a problem hiding this comment.
Oh sorry, I didn't realize that would work if it wasn't defined at some point. My bad! I'll add it to the next PR
| notifications_emails (List[str]): Notification email address(es) | ||
| compute_environment (str): Name or ID of compute environment to use, | ||
| if blank it will run in AWS | ||
| resume_dataset_id (str): ID of dataset to resume from, used for caching task execution. |
Contributor
There was a problem hiding this comment.
I wonder if we need to add that this doesn't apply to nextflow since it has the auto cache.
Contributor
Author
There was a problem hiding this comment.
Added a note on this
nathanthorpe
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK currently lacks a method for submitting an analysis that takes multiple inputs. This meets that need. I've tested it on some real data and it seems to work just fine.