feat: child folder mod locator#294
feat: child folder mod locator#294Gebardensprache wants to merge 6 commits intoCleanroomMC:experimental/foundationfrom
Conversation
- will not load child folder named `optional` or `disabled`
src/main/java/net/minecraftforge/fml/relauncher/libraries/LibraryManager.java
Outdated
Show resolved
Hide resolved
src/main/java/net/minecraftforge/fml/relauncher/libraries/LibraryManager.java
Outdated
Show resolved
Hide resolved
src/main/java/net/minecraftforge/fml/relauncher/libraries/LibraryManager.java
Outdated
Show resolved
Hide resolved
|
It is understandable that "disabled" is not loaded, but why is "optional" also considered. |
i will rewrite them all when i am home |
|
Maybe make the names configurable |
|
On a second thought, maybe make it configurable regex |
black/white list for scannable folder maybe |
- removed sub-sub folder compatible - add white/black list for special folder
src/main/java/net/minecraftforge/fml/relauncher/libraries/LibraryManager.java
Outdated
Show resolved
Hide resolved
| return stream | ||
| .filter(path -> { | ||
| Path parent = path.getParent(); | ||
| return parent == null || (Arrays.stream(ForgeEarlyConfig.SPECIAL_MOD_FOLDER).toList().contains(parent.getFileName().toString()) && ForgeEarlyConfig.IS_WHITELIST); |
There was a problem hiding this comment.
should the case be considered?
|
oh, my.error return parent!= null && !("disabled".equalsIgnoreCase(parent.getFileName().toString()) || "optional".equalsIgnoreCase(parent.getFileName().toString())); |
|
Should write a proposal for this, I guess |
- removed whitelist - inline var
|
may crash? |
Ecdcaeb
left a comment
Ecdcaeb
left a comment
There was a problem hiding this comment.
Looks good, let’s resolve the conflict.
Rongmario
added
the
proposal pending
5 participants
will not load child folder named
optionalordisabled