You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Split Slack notification channels to route pull request-related notifications and general release announcements to separate channels. Now, pull requests, such as chores, features, and fixes, are routed to a dedicated pull request channel for Click UI. For packages published to npm, these are announced in Click UI's general chat room to incentivise adoption and feedback as early as possible.
How?
Replaced SLACK_CHANNEL with SLACK_CHANNEL_FOR_PR in create-release.yml for release PR notifications
Replaced SLACK_CHANNEL with SLACK_CHANNEL_FOR_PR in pull-request-slack-notification.yml for new PR notifications
Replaced SLACK_CHANNEL with SLACK_CHANNEL_FOR_GENERAL in release-publisher.yml for npm package published announcements
Security checklist?
Sensitive data has been identified and is being protected properly
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This is a clean, focused change. The three one-line substitutions correctly map:
SLACK_CHANNEL → SLACK_CHANNEL_FOR_PR in create-release.yml and pull-request-slack-notification.yml
SLACK_CHANNEL → SLACK_CHANNEL_FOR_GENERAL in release-publisher.yml
The intent matches the implementation perfectly. Just make sure SLACK_CHANNEL_FOR_PR and SLACK_CHANNEL_FOR_GENERAL are configured as repository secrets before merging, otherwise the workflows will silently send to an empty channel. 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Split Slack notification channels to route pull request-related notifications and general release announcements to separate channels. Now, pull requests, such as chores, features, and fixes, are routed to a dedicated pull request channel for Click UI. For packages published to npm, these are announced in Click UI's general chat room to incentivise adoption and feedback as early as possible.
How?
SLACK_CHANNELwithSLACK_CHANNEL_FOR_PRincreate-release.ymlfor release PR notificationsSLACK_CHANNELwithSLACK_CHANNEL_FOR_PRinpull-request-slack-notification.ymlfor new PR notificationsSLACK_CHANNELwithSLACK_CHANNEL_FOR_GENERALinrelease-publisher.ymlfor npm package published announcementsSecurity checklist?
Preview?
N/A