Skip to content

chore: 🤖 split slack notifications (general vs pull requests)#919

Merged
punkbit merged 1 commit intomainfrom
chore/notify-slack-cui-package-published-npm-in-cui-channel
Mar 12, 2026
Merged

chore: 🤖 split slack notifications (general vs pull requests)#919
punkbit merged 1 commit intomainfrom
chore/notify-slack-cui-package-published-npm-in-cui-channel

Conversation

@punkbit
Copy link
Collaborator

@punkbit punkbit commented Mar 11, 2026

Why?

Split Slack notification channels to route pull request-related notifications and general release announcements to separate channels. Now, pull requests, such as chores, features, and fixes, are routed to a dedicated pull request channel for Click UI. For packages published to npm, these are announced in Click UI's general chat room to incentivise adoption and feedback as early as possible.

How?

  • Replaced SLACK_CHANNEL with SLACK_CHANNEL_FOR_PR in create-release.yml for release PR notifications
  • Replaced SLACK_CHANNEL with SLACK_CHANNEL_FOR_PR in pull-request-slack-notification.yml for new PR notifications
  • Replaced SLACK_CHANNEL with SLACK_CHANNEL_FOR_GENERAL in release-publisher.yml for npm package published announcements

Security checklist?

  • Sensitive data has been identified and is being protected properly
  • Build output contains no secrets or API keys

Preview?

N/A

@changeset-bot
Copy link

changeset-bot bot commented Mar 11, 2026

⚠️ No Changeset found

Latest commit: 4b0dba4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link

github-actions bot commented Mar 11, 2026

Claude finished @punkbit's task in 28s —— View job


PR Review

  • Gather context
  • Review changed files
  • Post findings

✅ Looks great! No issues found — nice work!

This is a clean, focused change. The three one-line substitutions correctly map:

  • SLACK_CHANNELSLACK_CHANNEL_FOR_PR in create-release.yml and pull-request-slack-notification.yml
  • SLACK_CHANNELSLACK_CHANNEL_FOR_GENERAL in release-publisher.yml

The intent matches the implementation perfectly. Just make sure SLACK_CHANNEL_FOR_PR and SLACK_CHANNEL_FOR_GENERAL are configured as repository secrets before merging, otherwise the workflows will silently send to an empty channel. 🙌

@workflow-authentication-public
Copy link
Contributor

📚 Storybook Preview Deployed

✅ Preview URL: https://click-8o187w3qw-clickhouse.vercel.app

Built from commit: 149f49279ac9bda7974371bd4daf13d460a1629b

@punkbit punkbit merged commit 8580486 into main Mar 12, 2026
11 checks passed
@punkbit punkbit deleted the chore/notify-slack-cui-package-published-npm-in-cui-channel branch March 12, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants