Skip to content

chore: 🤖 github actions maintenance (nodejs v20 action deprecation)#922

Merged
punkbit merged 3 commits intomainfrom
chore/maintenance-nodejs-v20-action-deprecation
Mar 12, 2026
Merged

chore: 🤖 github actions maintenance (nodejs v20 action deprecation)#922
punkbit merged 3 commits intomainfrom
chore/maintenance-nodejs-v20-action-deprecation

Conversation

@punkbit
Copy link
Collaborator

@punkbit punkbit commented Mar 12, 2026

Why?

GitHub's deprecating support for Nodejs v20 and actions will be forced to run a fallback version determined by GitHub, which, if the action is not well prepared to suit changes, it'll likely fail. For this reason, update the actions to the corresponding Node > 20 versions.

How?

  • Update the step action to the latest known version that runs Node > 20
  • Add a note for future maintainers regarding create github app token (yet to release stable, has a beta version for Node > 20)

Preview?

@changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2026

⚠️ No Changeset found

Latest commit: dccf486

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link

github-actions bot commented Mar 12, 2026

Claude finished @punkbit's task in 1m 48s —— View job


PR Review: GitHub Actions maintenance (Node.js v20 deprecation)

  • Read changed files
  • Review changes
  • Post findings

Nice, focused maintenance PR. The intent is clear and the approach is sound. A couple of things worth noting:

💡 Suggestions (non-blocking)

  • Version jump size: actions/checkout and actions/setup-node jump from v4v6 (skipping v5). Worth double-checking checkout releases and setup-node releases to confirm v6 is indeed the latest stable rather than an accidental skip. Similarly peter-evans/create-pull-request jumps from v5v8 — three major versions. If you've already verified these are correct, all good!

  • create-github-app-token@v2 in create-release.yml (line 103) and storybook-vercel.yml (line 33): The comment explaining why v3 isn't used yet is a great call for future maintainers. Consider opening a tracking issue to follow up once create-github-app-token@v3 goes stable, so it doesn't get forgotten.

  • storybook-vercel.yml line 39: setup-node@v6 appears in the current file but wasn't part of the diff (only the comment lines were added). Looks like it was already updated — just confirming the storybook workflow is consistent with the others. ✅

Everything else looks good — consistent version updates across all three workflows, the create-github-app-token situation is properly documented, and no unrelated changes crept in.

✅ Approved pending author confirming the version numbers are correct — if those are verified, this is ready to merge!

@github-actions
Copy link

github-actions bot commented Mar 12, 2026

Claude finished @punkbit's task in 46s —— View job


  • Read changed files
  • Review changes
  • Post findings

PR Review: GitHub Actions maintenance (Node.js v20 deprecation)

Clean, minimal maintenance PR. Changes are well-scoped and the create-github-app-token situation is properly documented for future maintainers.

Summary of changes reviewed:

  • create-release.yml: checkout@v4v6, create-pull-request@v5v8, added explanatory comment on create-github-app-token@v2
  • publish.yml: Two checkout@v4v6, setup-node@v4v6
  • storybook-vercel.yml: Added explanatory comment on create-github-app-token@v2 (action versions already updated in a prior commit)

💡 Suggestions (non-blocking)

  • Node version inconsistency (pre-existing, not introduced here): create-release.yml uses node-version: '23.x' while publish.yml uses node-version: '22.x'. Both are Node > 20, so neither is wrong, but aligning them would reduce maintenance surface. Worth a follow-up.

  • Tracking issue for create-github-app-token@v3: The comments are a great signal, but a GitHub issue to track the upgrade once v3 goes stable would ensure it doesn't get lost. The comment links to the releases page which helps, but an issue would give it a home in the backlog.

Everything else looks good — consistent updates across all three workflows, no unrelated changes, and the in-code comments give future maintainers the context they need.

✅ Ready to merge!

@workflow-authentication-public
Copy link
Contributor

📚 Storybook Preview Deployed

✅ Preview URL: https://click-nidski2kk-clickhouse.vercel.app

Built from commit: 7c477bf63db199b8adf8bdec2fb883f2e21b157c

@punkbit punkbit enabled auto-merge (squash) March 12, 2026 10:53
@punkbit punkbit merged commit a9791cf into main Mar 12, 2026
8 checks passed
@punkbit punkbit deleted the chore/maintenance-nodejs-v20-action-deprecation branch March 12, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants