Conversation
… client code is not recommended according to react official docs
🦋 Changeset detectedLatest commit: 97d804b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Claude finished @punkbit's task in 1m 7s —— View job PR ReviewGood change! Removing
🚨 Must Fix
💡 Suggestions (non-blocking)
|
📚 Storybook Preview Deployed✅ Preview URL: https://click-m42xretyr-clickhouse.vercel.app Built from commit: |
Why?
The following PR removes react-dom/server renderToStaticMarkup from copy grid elements of Grid to favour the recommended createRoot approach suggested by React's official documentation, because react dom's server version is not recommended by react themselves and shouldn't be surfacing publicly in the context of a component library.
According to React renderToStaticMarkup "The renderToStaticMarkup works in the browser, but using it in the client code is not recommended. If you need to render a component to HTML in the browser" and React renderToString "Importing react-dom/server on the client unnecessarily increases your bundle size and should be avoided. If you need to render some component to HTML in the browser, use createRoot and read HTML from the DOM".
How?
Preview?
Screen.Recording.2026-03-12.at.16.13.03.mov