Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
507aa28 to
d416e81
Compare
|
The docs look great! A couple of small pieces of feedback, but lgtm overall. I can't wait to get these in there I reviewed this preview on mobile: https://clickhouse-docs-9zj3bpftf-clickhouse.vercel.app/docs/integrations/apache-flink
|
docs/integrations/data-ingestion/apache-flink/flink-connector.md
Outdated
Show resolved
Hide resolved
docs/integrations/data-ingestion/apache-flink/flink-connector.md
Outdated
Show resolved
Hide resolved
docs/integrations/data-ingestion/apache-flink/flink-connector.md
Outdated
Show resolved
Hide resolved
docs/integrations/data-ingestion/apache-flink/flink-connector.md
Outdated
Show resolved
Hide resolved
docs/integrations/data-ingestion/apache-flink/flink-connector.md
Outdated
Show resolved
Hide resolved
BentsiLeviav
left a comment
There was a problem hiding this comment.
Left a few comments. In addition, can we go over the repo and find relevant locations where Flink is mentioned, and make sure we link them to this page?
Found these locations, but we might have more:
docs/integrations/data-ingestion/apache-flink/flink-connector.md
Outdated
Show resolved
Hide resolved
docs/integrations/data-ingestion/apache-flink/flink-connector.md
Outdated
Show resolved
Hide resolved
docs/integrations/data-ingestion/apache-flink/flink-connector.md
Outdated
Show resolved
Hide resolved
docs/integrations/data-ingestion/apache-flink/flink-connector.md
Outdated
Show resolved
Hide resolved
docs/integrations/data-ingestion/apache-flink/flink-connector.md
Outdated
Show resolved
Hide resolved
d37e53d to
5d8487b
Compare
5d8487b to
c211779
Compare
@BentsiLeviav yes - i confirmed the locations you identified are the only other mentions of flink in the repo besides the same pages in japanese & other languages. Should I update those as well? |
|
thanks @alexfrancoeur!
i've updated the flink icon link to point to the new docs page 👍
sure will do
yup, it's removed now |
9a10228 to
2a9c54a
Compare
a2f55b4 to
78c12c7
Compare
| ## Advanced and recommended usage {#advanced-and-recommended-usage} | ||
|
|
||
| - For optimal performance, ensure your DataStream element type is **not** a Generic type - see [here for Flink's type distinction](https://nightlies.apache.org/flink/flink-docs-release-2.2/docs/dev/datastream/fault-tolerance/serialization/types_serialization/#flinks-typeinformation-class). Non-generic elements will avoid the serialization overhead incurred by Kryo and improve throughput to ClickHouse. | ||
| - We recommend setting `maxBatchSize` to at least 1000 and ideally between 10,000 to 100,000. See [this guide on bulk inserts](https://clickhouse.com/docs/optimize/bulk-inserts) for more information. |
There was a problem hiding this comment.
items 12 and 15 in the doc matrix
Co-authored-by: Bentsi Leviav <bentsi.997@gmail.com>
@kurnoolsaketh no need to update any of the translations, there is a bot which will open a PR after this gets merged with any updates to translations. |
Blargian
left a comment
There was a problem hiding this comment.
LGTM, with exception that static/integrations-fallback.json shouldn't be checked in I don't think
Summary
Introduce documentation for the official Flink connector. This doc page is adapted from the flink connector repo's README.
closes: ClickHouse/flink-connector-clickhouse#110