[client-v2,jdbc-v2] Fix reading Date/Time values #2727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be stored as Integer
…is reduces number of conversions and makes logic simple
… dates are used for simpler reference
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
chernser
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...rc/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java
Outdated
Show resolved
Hide resolved
client-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/MapBackedRecord.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java
Show resolved
Hide resolved
…ime value and actual time from it
chernser
commented
Feb 1, 2026
...rc/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java
Show resolved
Hide resolved
chernser
commented
Feb 1, 2026
...rc/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java
Show resolved
Hide resolved
chernser
commented
Feb 1, 2026
...rc/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java
Show resolved
Hide resolved
chernser
commented
Feb 1, 2026
...rc/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java
Show resolved
Hide resolved
chernser
commented
Feb 1, 2026
...rc/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java
Show resolved
Hide resolved
chernser
commented
Feb 1, 2026
...rc/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java
Show resolved
Hide resolved
chernser
commented
Feb 1, 2026
client-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/MapBackedRecord.java
Show resolved
Hide resolved
client-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/MapBackedRecord.java
Show resolved
Hide resolved
...rc/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java
Show resolved
Hide resolved
...rc/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java
Show resolved
Hide resolved
|
mzitnik
reviewed
Feb 3, 2026
| * | ||
| * @return ClickHouseDataType | ||
| */ | ||
| public ClickHouseDataType getEffectiveDataType() { |
Contributor
There was a problem hiding this comment.
What is the difference between getDataType and getEffectiveDataType
I see that we call getEffectiveDataType every time we get time data
Maybe we can prepare it in advance?
Contributor
Author
There was a problem hiding this comment.
effective data type refer to aggregate function. It was an existing code and I have put it here to avoid forgetting.
Yes, this is the plan that we know how to convert each field and will remove this switch statements - basically for each column we will have a list of converter and it will be getConeverterForTargetClass(column, targetClass) call.
Where dynamic or variant columns - they will have same approach but list of converters will be calculated for each row (not a big over header expected because lists of converters are pre-baked). We using this approach in ResultSet for Arrays.
Contributor
Author
There was a problem hiding this comment.
After discussion we decided that we need just pre-calculate this data type to avoid getter chain
client-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/MapBackedRecord.java
Show resolved
Hide resolved
client-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/MapBackedRecord.java
Show resolved
Hide resolved
mzitnik
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes
Checklist
Delete items not relevant to your PR:
Note
Medium Risk
Medium risk because it changes the runtime types returned for
Date/Timecolumns (and their string/JDBC conversions), including a behavior change whereDateis no longer exposed asZonedDateTime, which can break downstream code relying on prior conversions.Overview
Client-v2 now decodes
Date/Date32asLocalDate(timezone-free) andTime/Time64as UTC-backedLocalDateTime, with newgetLocalTime()accessors and updatedgetString()/temporal getters to route through the appropriate typed value (includingDynamic/Variantcoercions).Adds
ClickHouseColumn.getEffectiveDataType()to consistently unwrapSimpleAggregateFunctioncolumns for conversion logic, improves null-handling for several getters (arrays, geo, inet, duration, enums), and updates the binary reader to emit the new date/time representations.JDBC v2 updates
ResultSetdate/time conversions to useLocalDateforDateandLocalDateTimeforTime, adds agetObject()shortcut forDate/Time/Timestamp, and extendsJdbcUtilsconversions (includingDurationfrom time values).Integration tests were added/updated to validate
Date/Timebehavior across time zones and support reading date/time values fromDynamic/Variant(plus refactoring/renaming of some JDBC tests).Written by Cursor Bugbot for commit b23d218. This will update automatically on new commits. Configure here.