fix: use starlette.exceptions.HTTPException for SPA fallback#14
Merged
lewisjared merged 1 commit intomainfrom Mar 6, 2026
Merged
fix: use starlette.exceptions.HTTPException for SPA fallback#14lewisjared merged 1 commit intomainfrom
lewisjared merged 1 commit intomainfrom
Conversation
StaticFiles.get_response raises starlette.exceptions.HTTPException, not fastapi.HTTPException (which is a subclass). The except clause was never catching the 404, causing the fallback to index.html to never trigger. Also adds tests verifying the SPA fallback behavior for client-side routes, static assets, and API routes.
✅ Deploy Preview for climate-ref canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StaticFiles.get_response raises starlette.exceptions.HTTPException, not fastapi.HTTPException (which is a subclass). The except clause was never catching the 404, causing the fallback to index.html to never trigger.
Also adds tests verifying the SPA fallback behavior for client-side routes, static assets, and API routes.