merge "generalize DF fit" into "reduce etas" #460
Open
kemccusker wants to merge 10 commits intoreduce_etasfrom
Open
merge "generalize DF fit" into "reduce etas" #460kemccusker wants to merge 10 commits intoreduce_etasfrom
kemccusker wants to merge 10 commits intoreduce_etasfrom
Conversation
This reverts commit 97040f3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generalize_df_fitcontains functionality to generalize the damage function fit step to work on different region typesreduce_etasadds anetadimension to the input data in the reduce damages step so that multipleetascan be processed at the same timeThis PR is to understand what the merging of those two disparate sets of functionality looks like, before merging anything to
main.