Skip to content

fix: prepend_child causes negative order values when reordering within same parent #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seuros merged 2 commits into from
Apr 7, 2026
+20 −1
Merged

fix: prepend_child causes negative order values when reordering within same parent #488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9083abb
fix: prepend_child sets order_value -1 causing siblings to reorder fr…
navaneethkp36 Apr 6, 2026
73e6b5e
fix: prepend_child causes negative order values when reordering withi…
navaneethkp36 Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/closure_tree/hierarchy_maintenance.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ def _ct_after_save
_ct_reorder_prior_siblings_if_parent_changed
_ct_reorder_siblings
elsif saved_changes[_ct.order_column_sym]
_ct_reorder_siblings(saved_changes[_ct.order_column_sym].min)
min = saved_changes[_ct.order_column_sym].min
_ct_reorder_siblings(min.negative? ? nil : min)
end
end
if saved_changes[_ct.parent_column_name] && !@was_new_record
Expand Down
18 changes: 18 additions & 0 deletions test/closure_tree/label_order_value_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,24 @@ def setup
assert_equal 1, c.reload.order_value
end

test 'prepend_child should produce 0-based order values when reordering within the same parent' do
root = Label.create(name: 'root')
a = root.children.create(name: 'a')
b = root.children.create(name: 'b')
c = root.children.create(name: 'c')

assert_equal 0, a.order_value
assert_equal 1, b.order_value
assert_equal 2, c.order_value

# Move c to be the first child (same parent, reorder only)
root.prepend_child(c)

assert_equal 0, c.reload.order_value
assert_equal 1, a.reload.order_value
assert_equal 2, b.reload.order_value
end

test 'should set order_value on roots for LabelWithoutRootOrdering' do
root = LabelWithoutRootOrdering.create(name: 'root')
assert_nil root.order_value
Expand Down