Open
Conversation
Take a look to see if I didn't mangle this. Trying to change link CTA to a crispy clear .svg button.
triceam
reviewed
Jul 19, 2021
| You can use IBM Cloud Schematics to deploy this Terraform template in the cloud without having a local terraform configuration. Just use this link: | ||
|
|
||
| - [Deploy on IBM Cloud](https://cloud.ibm.com/schematics/workspaces/create?repository=https://github.com/Cloud-Schematics/openshift-dev-cluster&terraform_version=terraform_v0.12) | ||
| [](https://cloud.ibm.com/schematics/workspaces/create?repository=https://github.com/Cloud-Schematics/openshift-dev-cluster&terraform_version=terraform_v0.12){: external} |
Collaborator
There was a problem hiding this comment.
2 things I see here:
-
This uses a relative URL for the SVG, this should probably be an absolute url. In the readme the image link is broken. If this is being rendered somewhere else, then it's probably broken there too.
-
The markdown doesn't look quite right. At the beginning there looks like an extra
[!, there's a{{site.data.keyword.cloud_notm}}reference, and at the end there's an extra{: external}annotation. Those annotations don't get rendered here on github. Are they supposed to show up somewhere else? Those look consistent with IBM Cloud Docs, which has a separate preprocessing process that they user during publication.z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take a look to see if I didn't mangle this. Trying to change link CTA to a crispy clear .svg button.