Skip to content

chore(proximo): remove proximo service#131

Merged
ignyx merged 14 commits intoClubInfoInsaT:masterfrom
pierrbt:remove-proximo
Apr 4, 2026
Merged

chore(proximo): remove proximo service#131
ignyx merged 14 commits intoClubInfoInsaT:masterfrom
pierrbt:remove-proximo

Conversation

@pierrbt
Copy link
Copy Markdown
Contributor

@pierrbt pierrbt commented Nov 6, 2025

Proximo API has been discontinued. I removed all proximo references because they were now useless.
This PR resolves #87
Feel free to comment any error I made.

I created a small script to reset the pinned items on the dashboard if it contained proximo, because else it would display a white square instead of another logo.

Here it is (in fact one of the only thing added) :

export function retrievePreferences<
  Keys extends PreferenceKeys,
  T extends Partial<PreferencesType>
>(keys: Array<Keys>, defaults: T): Promise<T> {
  return new Promise((resolve: (preferences: T) => void) => {
    AsyncStorage.multiGet(keys)
      .then((result) => {
        const preferences = { ...defaults };
        result.forEach((item) => {
          let [key, value] = item;
          if (value !== null) {
///// THIS PART IS ADDED
            if (key === "dashboardItems" && value.includes("proximo")) {
              // The user has changed the dashboard items
              // We need to replace Proximo because it isn't supported anymore (05/11/2025)
              // In order to do so, we reset the dashboard items to the default value
              value = defaultPreferences.dashboardItems;
              setPreference(PreferenceKeys.dashboardItems, value, defaults);
              console.log("Proximo successfully removed");
            }

///// END

            preferences[key as Keys] = value;
          }
        });
        resolve(preferences);
      })
      .catch(() => resolve(defaults));
  });
}

As you can see, the Proximo is no longer available.

image image

@pierrbt
Copy link
Copy Markdown
Contributor Author

pierrbt commented Nov 14, 2025

@ignyx Keep me up when you have time to review this

Copy link
Copy Markdown
Contributor

@ignyx ignyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great ! Thanks for looking into it.

I made a few minor change requests, and then we should be good to go 🎉

Additionally, npm run lint must pass. Run npm run lint-fix

Comment thread locales/en.json Outdated
Comment thread locales/es.json Outdated
Comment thread locales/fr.json Outdated
Comment thread locales/it.json Outdated
Comment thread .gitignore Outdated
@pierrbt
Copy link
Copy Markdown
Contributor Author

pierrbt commented Nov 20, 2025

@ignyx I need your help. I'm running the app on Windows, and all the errors are caused prettier, saying that CRLF are incorrect. However the .gitattributes files shows that they are supposed to be CRLF. How can I do to pass the tests ?

When I'm running lint-fix, it changes all my files to LF, which makes git want to commit 100+ files

@pierrbt
Copy link
Copy Markdown
Contributor Author

pierrbt commented Nov 20, 2025

I've changed the settings of prettier. Tell me if it's incorrect. Else I think everything looks ok.

@pierrbt pierrbt changed the title Remove Proximo chore(proximo): remove proximo service Nov 20, 2025
@pierrbt
Copy link
Copy Markdown
Contributor Author

pierrbt commented Dec 8, 2025

Any news about this ?

@ignyx
Copy link
Copy Markdown
Contributor

ignyx commented Dec 9, 2025

Sorry, been busy, I've noted to look into it this weekend 👍 Thanks for the changes !

@pierrbt
Copy link
Copy Markdown
Contributor Author

pierrbt commented Dec 9, 2025

I perfectly understand, take your time if you have other things planned.

@pierrbt
Copy link
Copy Markdown
Contributor Author

pierrbt commented Feb 24, 2026

@ignyx Is there any way I can help you for this ?

@ignyx
Copy link
Copy Markdown
Contributor

ignyx commented Feb 25, 2026

Hi ! Very sorry for the late. You've probably seen recent activity about the react-native upgrade. This was necessary in order to meet API/SDK version targets requirements set by the stores. As you've seen, it took a lot of time and energy. I'm nearing the end of it (or at least I think I am).

Once we've had a small internal round of testing to make sure the upgrade went well, I'll gladly merge your PRs !

@pierrbt
Copy link
Copy Markdown
Contributor Author

pierrbt commented Feb 25, 2026

Yes this looks like a big upgrade ! Congratulations for this and no problem for the delay these are not mandatory prs. Please tell me if you need something from me.

@pierrbt
Copy link
Copy Markdown
Contributor Author

pierrbt commented Feb 25, 2026

I will check if there is anything other than proximo that is not working any more (or not useful) and can be cleaned up

@ignyx
Copy link
Copy Markdown
Contributor

ignyx commented Feb 28, 2026

Hi! Thanks again for the contribution. Could you please:

  • drop the commits about adding/removing package-lock.json to .gitignore
  • drop the commits removing/adding package-lock.json
  • rebase onto main
  • regarding CRLF: can you investigate git config and prettier config and see if there is a way of configuring your git without changing the prettier configuration? If changes are required, can we please do so in another PR (and maybe merge it before your other PRs) ? Most contributors (and the current codebase) use Linux (so LF).


export type FullDashboardType = {
today_menu: Array<{ [key: string]: object }>;
proximo_articles: number;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may also remove it from the backend

@pierrbt
Copy link
Copy Markdown
Contributor Author

pierrbt commented Apr 3, 2026

@ignyx The history looks gross, but my branch is now perfectly cleaned up. Tell me if I need to modify anything.

Copy link
Copy Markdown
Contributor

@ignyx ignyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work with the git rebase !

It seems you resolved the CRLF issue, how did you do it ? Do you think a change like this could prevent other Windows contributors from facing similar issues ?

This PR looks good to me !

@ignyx ignyx merged commit 3ac53fb into ClubInfoInsaT:master Apr 4, 2026
1 check passed
@pierrbt
Copy link
Copy Markdown
Contributor Author

pierrbt commented Apr 4, 2026

I will try tomorrow whether or not it fixes the issue (i think it Will). I just ran the lint fix with prettier config override and it did not put all the files as changed, so it was only a local override.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove Proximo

2 participants