Skip to content

Doc: Pacemaker Explained: Add index entries for resource meta-attribu…#4061

Open
clumens wants to merge 1 commit intoClusterLabs:mainfrom
clumens:t199
Open

Doc: Pacemaker Explained: Add index entries for resource meta-attribu…#4061
clumens wants to merge 1 commit intoClusterLabs:mainfrom
clumens:t199

Conversation

@clumens
Copy link
Contributor

@clumens clumens commented Feb 23, 2026

…tes.

Fixes T199

@clumens clumens requested a review from nrwahl2 February 23, 2026 16:52
Copy link
Contributor

@nrwahl2 nrwahl2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contents look good given the approach being used. I have a couple of thoughts on that approach though.


I think we should drop the resource; option, <name> lines, since the resource; meta-attribute, <name> lines make them redundant.


Also, looking at T199, I see that Ken's description was:

Add index entries for "resource; meta-attribute" as well as "resource meta-attribute; attribute name" for each meta-attribute

You noted:

I think the first entry is supposed to be "resource; meta-attribute, attribute name". Otherwise the generated index looks incorrect.

I agree, if we're talking about the both entries being per-attribute. However, here is my interpretation of Ken's description:

  • index entry "resource; meta-attribute" attached to the section containing the main meta-attributes table: "Resource Meta-Attributes"
  • single index entry "resource meta-attribute; attribute name" for each meta-attribute

In that case, we would no longer have the comma-separated entries like the current "option, priority" nested under the top-level "resource" entry. Rather, we'd have a top-level "resource meta-attribute" entry, with "priority" (etc.) nested underneath it.


Thoughts on each of the above?

@clumens
Copy link
Contributor Author

clumens commented Feb 27, 2026

Here's a quick tip: Don't look at the generated index unless you want to start seeing inconsistencies you want to fix. Sigh.

@clumens
Copy link
Contributor Author

clumens commented Feb 27, 2026

I think we should drop the resource; option, <name> lines, since the resource; meta-attribute, <name> lines make them redundant.

Yeah agreed. We don't have a big block like that anywhere else in Pacemaker Explained except for under clone (see previous comment about finding inconsistencies).

I agree, if we're talking about the both entries being per-attribute. However, here is my interpretation of Ken's description:

* index entry "resource; meta-attribute" attached to the section containing the main meta-attributes table: "Resource Meta-Attributes"

* single index entry "resource meta-attribute; attribute name" for each meta-attribute

In that case, we would no longer have the comma-separated entries like the current "option, priority" nested under the top-level "resource" entry. Rather, we'd have a top-level "resource meta-attribute" entry, with "priority" (etc.) nested underneath it.

I think what I want is three things:

  • Top level resource meta-attribute with every meta-attribute listed under it. For instance:
resource meta-attribute
    allow-migrate, 40
    allow-unhealthy-nodes, 40
    ...
  • Top level resource with each meta-attribute, attribute listed under it. For instance:
resource, 35
    ...
    meta-attribute, allow-migrate, 40
    meta-attribute, allow-unhealthy-nodes, 40
    ...

I think this is what you're suggesting I get rid of, but if you look through the rest of the index, you'll see plenty of sub-lists like this. On the other hand, just looking at this same page of the index, I don't see any other instances of having both this and the previous thing I listed. For example, rsc_colocation looks like this:

rsc_colocation
    attribute, id, 60
    attribute, influence, 61
    ...

And not this:

rsc_colocation
    attribute, id, 60
    attribute, influence, 61
    ...
rsc_colocation attributes
    id, 60
    influence, 61
    ...

I could go either way with it. I could also be convinced that broader changes are needed.

  • Okay finally the third thing. I think every meta-attribute should be listed like this:
remote-allow-migrate
    resource meta-attribute, 44

Instead of the current:

remote-allow-migrate
    resource option, 44

@clumens
Copy link
Contributor Author

clumens commented Feb 27, 2026

I just noticed this. There's also a top-level meta-attribute entry with some things under it:

meta-attribute
    alert meta-attributes, 130
    enabled (alert), 130
    ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants