Doc: Pacemaker Explained: Add index entries for resource meta-attribu…#4061
Doc: Pacemaker Explained: Add index entries for resource meta-attribu…#4061clumens wants to merge 1 commit intoClusterLabs:mainfrom
Conversation
nrwahl2
left a comment
There was a problem hiding this comment.
The contents look good given the approach being used. I have a couple of thoughts on that approach though.
I think we should drop the resource; option, <name> lines, since the resource; meta-attribute, <name> lines make them redundant.
Also, looking at T199, I see that Ken's description was:
Add index entries for "resource; meta-attribute" as well as "resource meta-attribute; attribute name" for each meta-attribute
You noted:
I think the first entry is supposed to be "resource; meta-attribute, attribute name". Otherwise the generated index looks incorrect.
I agree, if we're talking about the both entries being per-attribute. However, here is my interpretation of Ken's description:
- index entry "resource; meta-attribute" attached to the section containing the main meta-attributes table: "Resource Meta-Attributes"
- single index entry "resource meta-attribute; attribute name" for each meta-attribute
In that case, we would no longer have the comma-separated entries like the current "option, priority" nested under the top-level "resource" entry. Rather, we'd have a top-level "resource meta-attribute" entry, with "priority" (etc.) nested underneath it.
Thoughts on each of the above?
|
Here's a quick tip: Don't look at the generated index unless you want to start seeing inconsistencies you want to fix. Sigh. |
Yeah agreed. We don't have a big block like that anywhere else in Pacemaker Explained except for under clone (see previous comment about finding inconsistencies).
I think what I want is three things:
I think this is what you're suggesting I get rid of, but if you look through the rest of the index, you'll see plenty of sub-lists like this. On the other hand, just looking at this same page of the index, I don't see any other instances of having both this and the previous thing I listed. For example, And not this: I could go either way with it. I could also be convinced that broader changes are needed.
Instead of the current: |
|
I just noticed this. There's also a top-level |
…tes.
Fixes T199