Add Spanish localization files for CoFH Core 1.20.1#57
Open
ArrivedBog593 wants to merge 9 commits intoCoFH:1.20.1from
Open
Add Spanish localization files for CoFH Core 1.20.1#57ArrivedBog593 wants to merge 9 commits intoCoFH:1.20.1from
ArrivedBog593 wants to merge 9 commits intoCoFH:1.20.1from
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Spanish (Mexico and Spain) localization coverage for CoFH Core 1.20.1 by introducing new es_mx and es_es language JSON files alongside the existing locale set.
Changes:
- Added
es_mx.jsonSpanish (Mexico) translations for CoFH Core/common strings. - Added
es_es.jsonSpanish (Spain) translations for the same key set.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| src/main/resources/assets/cofh_core/lang/es_mx.json | New Spanish (Mexico) locale entries for CoFH Core/common UI strings and tooltips. |
| src/main/resources/assets/cofh_core/lang/es_es.json | New Spanish (Spain) locale entries mirroring the key set for CoFH Core/common UI strings and tooltips. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+67
to
+68
| "info.cofh.unit_rf": "FR", | ||
| "info.cofh.unit_rf_t": "FR/t", |
There was a problem hiding this comment.
These are unit abbreviations for Redstone Flux and are kept as "RF" in other locale files (e.g., ja_jp/zh_cn/ru_ru). Using "FR" here is likely incorrect/inconsistent and will display the wrong unit.
Suggested change
| "info.cofh.unit_rf": "FR", | |
| "info.cofh.unit_rf_t": "FR/t", | |
| "info.cofh.unit_rf": "RF", | |
| "info.cofh.unit_rf_t": "RF/t", |
Comment on lines
+67
to
+68
| "info.cofh.unit_rf": "FR", | ||
| "info.cofh.unit_rf_t": "FR/t", |
There was a problem hiding this comment.
These are unit abbreviations for Redstone Flux and are kept as "RF" in other locale files (e.g., ja_jp/zh_cn/ru_ru). Using "FR" here is likely incorrect/inconsistent and will display the wrong unit.
Suggested change
| "info.cofh.unit_rf": "FR", | |
| "info.cofh.unit_rf_t": "FR/t", | |
| "info.cofh.unit_rf": "RF", | |
| "info.cofh.unit_rf_t": "RF/t", |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.