Conversation
gabrielbmoro
commented
Sep 10, 2025
| uses: ./.github/actions/setup-flutter | ||
|
|
||
|
|
||
| - name: Generate code |
Contributor
Author
There was a problem hiding this comment.
Add a new step before run the tests considering Mock framework generates code
gabrielbmoro
commented
Sep 10, 2025
| final bookDetails = await _getBookDetails(id: bookId!); | ||
| return BookDetailsUI.fromDomain(bookDetails); | ||
| } else { | ||
| emit(state.copyWith(errorMessage: "Book ID is null")); |
Contributor
Author
There was a problem hiding this comment.
Remove this considering we are already emitting the state in the proper method caller (dart analyze pointed an issue here, we cannot emit without being in a scope of event (on ...)
gabrielbmoro
commented
Sep 10, 2025
Contributor
Author
There was a problem hiding this comment.
remove commented test
gabrielbmoro
commented
Sep 10, 2025
Contributor
Author
There was a problem hiding this comment.
Solve unit tests issue
gabrielbmoro
commented
Sep 10, 2025
Contributor
Author
There was a problem hiding this comment.
Remove generated test (not used)
gabrielbmoro
commented
Sep 10, 2025
| ); | ||
| } catch (e) { | ||
| print('Error during pagination: $e'); | ||
| debugPrint('Error during pagination: $e'); |
Contributor
Author
There was a problem hiding this comment.
analyze requires us to use debugPrint instead
pnalvarez
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #2