Add Forgot Password link on Sign In page #1370
Conversation
|
@pratyushjha06 is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE. |
Avdhesh-Varshney
left a comment
Avdhesh-Varshney
left a comment
There was a problem hiding this comment.
@pratyushjha06 use nodemailer to send mail. Create api for this
|
@pratyushjha06 Please complete all mentioned changes |
Working on it |
|
@pratyushjha06 Are you working on the changes? Issue was unassigned due to github issue automation workflow. If you are working, ping me. I'll reassign it to you. |
Yes pls reassign am working on it, and will commit the changes soon |
|
I've reassign and set last date to be 4 feb. But complete your changes by today or tomorrow. |
pratyushjha06
force-pushed
the
add-forgot-password-link
branch
from
3cc9138 to
813d7f6
Compare
@Avdhesh-Varshney Done Pls Check |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Avdhesh-Varshney
left a comment
Avdhesh-Varshney
left a comment
There was a problem hiding this comment.
Try to complete it them today, I'll review in morning.
| setSuccess(false); | ||
|
|
||
| try { | ||
| const response = await fetch('http://localhost:8000/api/auth/forgot-password', { |
There was a problem hiding this comment.
Write the api call inside /infra/rest folder - according to auth directory.
Before writing, please take a look on implementation / use case of api call function.
| return sendResponse(res, 400, 'Email is required'); | ||
| } | ||
|
|
||
| // TODO: Check if user exists in database |
There was a problem hiding this comment.
Why are there a commented for TODOs?
All these changes required, implement & keep it.
@pratyushjha06 Box bg is already red and text is also red. Have you test everything? Please share me a full working video from entering email to resetting password. |
|
@pratyushjha06 Bro try to complete it by today. Is it possible? |
2 participants
Pull Requests Review Criteria
Caution
PRs that fail to meet these review standards will be automatically flagged and may be rejected by maintainers.
mainCloses: #1277
Describe the add-ons or changes you've made 📃
Added a "Forgot Password?" link on the Sign In page that redirects users to a password reset page.
Changes:
/reset-passwordrouteThe UI is complete. Backend email functionality will be added separately.
Screenshots 📷
09-22-14.-.Trim.mp4
Note to reviewers (Optional) 📄