Conversation
aedwardg
left a comment
aedwardg
left a comment
There was a problem hiding this comment.
I think this is a good starting place, though ideally I'd like to keep PRs much smaller than this. This may just be a side-effect of not having a designer on the team though.
I think this is good to merge except there seems to be some git weirdness that happened when you were trying to merge in existing changes from main.
In the following screenshot, commits 1 and 2 shouldn't be there and 3 should be merging main into experimental-merge-of-designs.
I'm happy to help fix this if needed
| theme: { | ||
| colors: { | ||
| background: "#b3b3b3", | ||
| // background: "#4d4d4d", |
There was a problem hiding this comment.
We can get rid of this comment
There was a problem hiding this comment.
This was just testing with a dark theme color. Something that can be looked at a later point in time.
There was a problem hiding this comment.
A lot of this CSS can be removed without changing the way the page looks. That can be done in a follow-up ticket though in order to move things forward.
| {/* </div>*/} | ||
| {/*</div>*/} |
| <link | ||
| href="https://fonts.googleapis.com/css2?family=Inter:ital,opsz,wght@0,14..32,100..900;1,14..32,100..900&display=swap" | ||
| rel="stylesheet" | ||
| /> |
There was a problem hiding this comment.
Not sure if we're even using this font. I deleted this locally and nothing changed.
Cykotech
force-pushed
the
experimental-merge-of-designs
branch
from
1636ef2 to
411a11c
Compare
3 participants
What issue is this solving?
Closes #28
Description
Merged both design concepts.
Any helpful knowledge/context for the reviewer?
Feelings gif (optional)
Please make sure you've attempted to meet the following coding standards