Conversation
…end app loading to with account-hooks completion
…end app loading to with account-hooks completion
…creeners linked to the user
561a149 to
4e56da1
Compare
|
@prestoncabe |
There was a problem hiding this comment.
Hey @joshwanf , thanks for working on this!
I was able to successfully see the example screener in a new (email/pw) account created on my local machine, nice.
A couple of issues I noticed myself:
- I wasn't able to see the copy of the screener when signing in with a new google account.
- You have two pairs of git commits with the same commit message, which confused me.
I also asked claude to do a review and attached the report. The two biggest things are the Google signup issue and another issue related to promises that I don't really understand (not my expertise). The other things seem small or just cleanup that can be addressed quickly.
Let's at least address the two bugs before merging.
|
Sounds doable. I rebased this branch twice so I'm thinking that's where the duplicate commits came from. Can you upload the Claude review file again? It gives me a 404 when I try to access it |
hmm, that shouldn't happen if doing rebase properly. Can you send me the command you did? I'm wondering if you rebased the branch on top of itself?
Here's the same file again... but I downloaded from the original link and didn't get a 404, so maybe that was an intermittent issue with github? |
Resolves #273
Create an account action follows this flow:
.then()calls backend'sPOST /api/account-hookswith an array of side-effect hooks to run. If Google sign in was used,.then()checks foruserCredential.operationTypeaslinkorreauthenticate.<ProtectedRoute>checks for anisProvisioningAccountsignal to sync loading AFTER backend finishes.Currently,
AccountHookActionis an enum of only "add example screener." A Map connects anAccountHookActionto a function, so new hooks can be added.