-
Notifications
You must be signed in to change notification settings - Fork 163
feats: extend ValuePool by new fields : files, and maxMutations #1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR extends the @ValuePool annotation to support two new capabilities: (1) loading files as byte arrays using glob patterns via a new files field, and (2) controlling mutation iterations via a new maxMutations field.
Changes:
- Added
filesfield to@ValuePoolannotation for glob-based file loading - Added
maxMutationsfield to control mutation iterations on pool values - Implemented file pattern matching and path resolution in
ValuePoolRegistry - Updated mutation logic to apply multiple mutations based on
maxMutations - Added caching for ArgumentsMutator instances and file reads
- Comprehensive test coverage for file loading feature
- Extensive documentation updates
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 16 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/com/code_intelligence/jazzer/mutation/annotation/ValuePool.java | Added files and maxMutations fields to annotation with documentation |
| src/main/java/com/code_intelligence/jazzer/mutation/support/ValuePoolRegistry.java | Implemented glob pattern matching, file loading, and maxMutations extraction with path resolution logic |
| src/main/java/com/code_intelligence/jazzer/mutation/mutator/lang/ValuePoolMutatorFactory.java | Updated mutate/crossOver to apply multiple mutations based on maxMutations |
| src/test/java/com/code_intelligence/jazzer/mutation/support/ValuePoolsTest.java | Added comprehensive tests for file loading patterns and updated test helpers |
| src/main/java/com/code_intelligence/jazzer/mutation/ArgumentsMutator.java | Added caching for ArgumentsMutator instances to improve performance |
| src/main/java/com/code_intelligence/jazzer/junit/FuzzTestExecutor.java | Set system property for baseDir to enable ValuePoolRegistry file resolution |
| docs/mutation-framework.md | Added extensive documentation for ValuePool features including examples and usage patterns |
Comments suppressed due to low confidence (1)
src/test/java/com/code_intelligence/jazzer/mutation/support/ValuePoolsTest.java:415
- The test helper withValuePoolImplementation is missing the maxMutations() method implementation. Since maxMutations() is now part of the @valuepool annotation interface, this anonymous implementation must override it. Without this method, using this test helper will result in runtime errors when the annotation's maxMutations() method is called.
return new ValuePool() {
@Override
public String[] value() {
return value;
}
@Override
public String[] files() {
return files;
}
@Override
public double p() {
return p;
}
@Override
public String constraint() {
return constraint;
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/com/code_intelligence/jazzer/mutation/support/ValuePoolRegistry.java
Outdated
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/mutation/annotation/ValuePool.java
Outdated
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/mutation/support/ValuePoolRegistry.java
Outdated
Show resolved
Hide resolved
src/test/java/com/code_intelligence/jazzer/mutation/support/ValuePoolsTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/mutation/mutator/lang/ValuePoolMutatorFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/mutation/support/ValuePoolRegistry.java
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/mutation/mutator/lang/ValuePoolMutatorFactory.java
Show resolved
Hide resolved
ed09c59 to
e2cc773
Compare
42a3a15 to
6d874ba
Compare
6d874ba to
112ab04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/test/java/com/code_intelligence/jazzer/mutation/support/ValuePoolsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/code_intelligence/jazzer/mutation/support/ValuePoolsTest.java
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/mutation/support/ValuePoolRegistry.java
Outdated
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/mutation/support/ValuePoolRegistry.java
Outdated
Show resolved
Hide resolved
src/test/java/com/code_intelligence/jazzer/mutation/support/ValuePoolsTest.java
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/mutation/mutator/lang/ValuePoolMutatorFactory.java
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/mutation/mutator/lang/ValuePoolMutatorFactory.java
Outdated
Show resolved
Hide resolved
The number of fields in ValuePool is getting large, so that construction using positional args is becoming confusing. Using a builder simplifies the tests.
Don't generate the same mutator for the same fuzz test method multiple times. Before this change, a mutator was generated for each crash file in fuzzing mode.
112ab04 to
49403fd
Compare
Marcono1234
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully these comments are useful. Feel free to consider them only as suggestions or ignore them completely.
Please let me know if these comments are not useful or if you consider them disruptive.
src/main/java/com/code_intelligence/jazzer/mutation/annotation/ValuePool.java
Outdated
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/mutation/annotation/ValuePool.java
Outdated
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/mutation/support/ValuePoolRegistry.java
Outdated
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/mutation/support/ValuePoolRegistry.java
Outdated
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/mutation/support/ValuePoolRegistry.java
Outdated
Show resolved
Hide resolved
src/test/java/com/code_intelligence/jazzer/mutation/support/ValuePoolsTest.java
Show resolved
Hide resolved
src/test/java/com/code_intelligence/jazzer/mutation/support/ValuePoolsTest.java
Show resolved
Hide resolved
@Marcono1234 Your reviews are welcome, and helpful 😄 Thanks! |
49403fd to
4818c8e
Compare
4818c8e to
a16453d
Compare
@ValuePoolannotation by using the new fieldString[] files---files matching the patterns will be loaded asbyte []. The field uses theglob:syntax ofjava.nio.file.PathMatcher.Example:
maxMutations, the users can now control up to how many times (by default 1) values selected from@ValuePoolwill be mutated by the underlying mutator in one mutation operation.