-
-
Notifications
You must be signed in to change notification settings - Fork 29
London | 25-SDC-July | Rihanna Poursoltani | Sprint 2 | Improve code with caches #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,12 @@ | ||
| memo = {} | ||
|
|
||
| def fibonacci(n): | ||
| if n in memo: | ||
| return memo[n] | ||
|
|
||
| if n <= 1: | ||
| return n | ||
| return fibonacci(n - 1) + fibonacci(n - 2) | ||
| result = fibonacci(n - 1) + fibonacci(n - 2) | ||
| memo[n] = result | ||
|
|
||
| return result |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,32 +1,57 @@ | ||
| from typing import List | ||
|
|
||
| from typing import List, Dict, Tuple | ||
|
|
||
| def ways_to_make_change(total: int) -> int: | ||
| """ | ||
| Given access to coins with the values 1, 2, 5, 10, 20, 50, 100, 200, returns a count of all of the ways to make the passed total value. | ||
| # Pre-create only 8 possible "coins" arrays | ||
| _BASE_COINS: List[int] = [200, 100, 50, 20, 10, 5, 2, 1] | ||
| COIN_SUFFIXES: List[Tuple[int, ...]] = [tuple(_BASE_COINS[i:]) for i in range(len(_BASE_COINS))] | ||
|
RihannaP marked this conversation as resolved.
Outdated
|
||
|
|
||
| For instance, there are two ways to make a value of 3: with 3x 1 coins, or with 1x 1 coin and 1x 2 coin. | ||
| """ | ||
| return ways_to_make_change_helper(total, [200, 100, 50, 20, 10, 5, 2, 1]) | ||
| cache: Dict[Tuple[int, int], int] = {} | ||
|
|
||
| def ways_to_make_change(total: int) -> int: | ||
| cache.clear() | ||
| # suffix_id == 0 identifies [200, 100, 50, 20, 10, 5, 2, 1] | ||
| return ways_to_make_change_helper(total, suffix_id=0) | ||
|
|
||
|
|
||
| def ways_to_make_change_helper(total: int, coins: List[int]) -> int: | ||
| def ways_to_make_change_helper(total: int, suffix_id: int) -> int: | ||
| """ | ||
| Helper function for ways_to_make_change to avoid exposing the coins parameter to callers. | ||
| suffix_id uniquely identifies the subarray coins = COIN_SUFFIXES[suffix_id] | ||
| where suffix_id in [0..7]. | ||
| """ | ||
| if total == 0 or len(coins) == 0: | ||
| key = (total, suffix_id) | ||
| if key in cache: | ||
| return cache[key] | ||
|
|
||
| coins = COIN_SUFFIXES[suffix_id] | ||
|
|
||
| # Keep behavior close to original, but fix the standard base case: | ||
| if total == 0: | ||
| return 1 | ||
| if len(coins) == 0: | ||
| return 0 | ||
|
|
||
| if len(coins) == 1: | ||
| cache[key] = 1 if (total % coins[0] == 0) else 0 | ||
| return cache[key] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note: Even though tuple construction and dictionary lookup (lines 21 and 22) are O(1) operations, This is unrelated to cache, but if you swap the code on lines 28-33 with the code on lines 21-23, Good job in figuring out a quicker way to compute number of ways when there is only one coin left to consider.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed. Checking that before doing cache lookup avoids unnecessary tuple creation and dictionary access |
||
|
|
||
| ways = 0 | ||
| for coin_index in range(len(coins)): | ||
| coin = coins[coin_index] | ||
| count_of_coin = 1 | ||
|
|
||
| while coin * count_of_coin <= total: | ||
| total_from_coins = coin * count_of_coin | ||
|
|
||
| if total_from_coins == total: | ||
| ways += 1 | ||
| else: | ||
| intermediate = ways_to_make_change_helper(total - total_from_coins, coins=coins[coin_index+1:]) | ||
| ways += intermediate | ||
| # Instead of slicing coins[coin_index+1:], move the suffix_id forward. | ||
| # suffix_id is the start index of `coins` in the base list, so: | ||
| next_suffix_id = suffix_id + coin_index + 1 | ||
| if next_suffix_id < len(COIN_SUFFIXES): | ||
| ways += ways_to_make_change_helper(total - total_from_coins, suffix_id=next_suffix_id) | ||
|
|
||
| count_of_coin += 1 | ||
|
|
||
| cache[key] = ways | ||
| return ways | ||
Uh oh!
There was an error while loading. Please reload this page.