-
-
Notifications
You must be signed in to change notification settings - Fork 225
Manchester | 26-ITP-Jan | Liban Jama | Sprint 1 | Object Destructing #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
libanj0161
wants to merge
6
commits into
CodeYourFuture:main
Choose a base branch
from
libanj0161:feature/destructuring
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+62
−1
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
897b026
completed exercise 1
libanj0161 747df19
Completed exercise 2
libanj0161 d906c91
Completed exercise 3
libanj0161 58000c1
console logs added
libanj0161 c2a062e
edited after feedback
libanj0161 e8e1231
Called functions
libanj0161 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -70,3 +70,38 @@ let hogwarts = [ | |
| occupation: "Teacher", | ||
| }, | ||
| ]; | ||
|
|
||
| function findGryffindor(peopleList) { | ||
| // first loop through the people list | ||
| // find every person whos is Gryffindor house | ||
| const gryffindorPeople = peopleList.filter(({ house }) => { | ||
| return house === "Gryffindor"; | ||
| }); | ||
|
|
||
| const peopleNames = gryffindorPeople.map(({ firstName, lastName }) => { | ||
| return `${firstName} ${lastName}`; | ||
| }); | ||
|
|
||
| const output = peopleNames.join("\n"); | ||
| console.log("People in Gryffindor House", output); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How could you improve the formatting of the output? (so that the headers are on top) |
||
| return output; | ||
| } | ||
|
|
||
| function findTeachersWithPets(peopleList) { | ||
| // loop through peoples list | ||
| // find teachers with pets | ||
| const teachersWithPets = peopleList.filter(({ occupation, pet }) => { | ||
| return pet && occupation === "Teacher"; | ||
| }); | ||
|
|
||
| const teachersName = teachersWithPets.map(({ firstName, lastName }) => { | ||
| return `${firstName} ${lastName}`; | ||
| }); | ||
|
|
||
| const output = teachersName.join("\n"); | ||
| console.log("Teachers with pets", output); | ||
| return output; | ||
| } | ||
|
|
||
| findTeachersWithPets(hogwarts); | ||
| findGryffindor(hogwarts); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any output on the console when I run this exercise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added console logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are you verifying that the output is correct?