Skip to content

Manchester | 26-ITP-Jan | Ofonime Edak | Sprint 1 | Feature/Destructuring#407

Open
Ofonimeedak wants to merge 5 commits intoCodeYourFuture:mainfrom
Ofonimeedak:feature/destructuring
Open

Manchester | 26-ITP-Jan | Ofonime Edak | Sprint 1 | Feature/Destructuring#407
Ofonimeedak wants to merge 5 commits intoCodeYourFuture:mainfrom
Ofonimeedak:feature/destructuring

Conversation

@Ofonimeedak
Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Update and destructuring argument for a function
Write a function for the teacher's pet
print receipt function

@Ofonimeedak Ofonimeedak added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Flows The name of the module. labels Apr 5, 2026
@Luro91 Luro91 added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 10, 2026
}

introduceYourself(personOne);
console.log(introduceYourself(personOne));
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this log?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any console output here

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It logs this message to the console: Hello, my name is Popeye. I am 34 years old and my favourite food is Spinach.

When I run this on my terminal: Module-Data-Flows\sprint-1\destructuring\exercise-1> node exercise.js

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment refers to exercise 2

return totalCost;
}, 0);
const finalBill = grandTotal.toFixed(2);
console.log(`Total:${finalBill}`);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting of the console output does not match the requirements

@Luro91 Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 10, 2026
@Ofonimeedak Ofonimeedak requested a review from Luro91 April 11, 2026 18:22
Copy link
Copy Markdown

@Luro91 Luro91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the correct label next time when you need another review as I am using them to see where I need to rereview

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment refers to exercise 2


function orderReceipt(orderItems) {
const totalList = [];
console.log("QUANTITY ITEM TOTAL");
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text should say "QTY"

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I have worked on this. Please kindly review

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still the same

@Ofonimeedak Ofonimeedak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 15, 2026
@Ofonimeedak Ofonimeedak requested a review from Luro91 April 15, 2026 10:42
const { firstName, lastName, house } = mate;
if (house === "Gryffindor") {
const gryffindorMates = `${firstName} ${lastName} lives in `;
console.log(gryffindorMates);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output does not match the requirements:
I like the idea of making the logs more specific. However where to the people live in?

Harry Potter lives in 
Ron Weasley lives in 
Hermione Granger lives in 
Minerva McGonagall lives in 
Albus Dumbledore lives in 
Harry Potter has a pet
Ron Weasley has a pet
Hermione Granger has a pet
Albus Dumbledore has a pet

@Luro91 Luro91 removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Data-Flows The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants