Sheffield | 26-ITP-Jan | Mahmoud Shaabo | Sprint 1 | Object Destructuring#425
Open
mahmoudshaabo1984 wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
Sheffield | 26-ITP-Jan | Mahmoud Shaabo | Sprint 1 | Object Destructuring#425mahmoudshaabo1984 wants to merge 1 commit intoCodeYourFuture:mainfrom
mahmoudshaabo1984 wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
Author
|
Hi CJ, I have just submitted my Pull Request for the Sprint 1 Object Destructuring exercises. The acceptance criteria have been met and the code is ready for your review whenever you have time. Thank you! |
mahmoudshaabo1984
added
the
Needs Review
cjyuan
reviewed
Apr 16, 2026
Comment on lines
+32
to
+34
| console.log( | ||
| String(quantity).padEnd(8) + itemName.padEnd(20) + itemTotal.toFixed(2) | ||
| ); |
Contributor
There was a problem hiding this comment.
Good idea to use padEnd() to align the item in the first two columns.
How would you modify this code to align the value of itemTotal when its value is 10.00 or more?
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Reviewers / CodeYourFuture Team,
I have completed the Object Destructuring exercises for Sprint 1.
Acceptance Criteria Met:
introduceYourselffunction parameter inexercise-1to use object destructuring directly.for...ofloops and object destructuring inexercise-2to accurately filter Gryffindor members and teachers with pets.exercise-3to calculate the total cost and formatted the console output correctly.Thank you for your review!