Skip to content

Sheffield | 26-ITP-Jan | Mahammad Osman | Sprint 2 | Book Library#426

Open
Darkidd77 wants to merge 9 commits intoCodeYourFuture:mainfrom
Darkidd77:feature/book-library
Open

Sheffield | 26-ITP-Jan | Mahammad Osman | Sprint 2 | Book Library#426
Darkidd77 wants to merge 9 commits intoCodeYourFuture:mainfrom
Darkidd77:feature/book-library

Conversation

@Darkidd77
Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Fixed missing parentheses that stopped books from showing on load.
  • Found and fixed a misspelled variable delButdelButton using DevTools console error.
  • Fixed inverted read/unread logic so "Yes" and "No" display correctly.
  • Author field was missing from form validation — added it in.
  • Changed invalid input types type="title" and type="author" to type="text".
  • Gave the page an actual title instead of leaving it blank.
  • Form now clears itself after adding a book.

@Darkidd77 Darkidd77 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 13, 2026
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You made a good start and fix the bugs, but there are still some improvements you could make. Can you check (again) if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants