Skip to content

London | JAN-ITP-26 | Damian Dunkley | Sprint 2 | Book Library #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DamianDL wants to merge 13 commits into
base: main
Choose a base branch
from
Open

London | JAN-ITP-26 | Damian Dunkley | Sprint 2 | Book Library #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ff95662
Refactored code to provide list of books
DamianDL Apr 13, 2026
332b11f
Refactored code to enable books to be added, author field updates cor…
DamianDL Apr 13, 2026
d539435
Refactored code using validator w3 to check
DamianDL Apr 14, 2026
be162d8
Refactored code using validator w3 to check
DamianDL Apr 14, 2026
653d361
Refactored code as per CJ Update
DamianDL Apr 14, 2026
a46d754
Refactored code to only call render once on page load and remove unus…
DamianDL Apr 14, 2026
633689d
Refactored code to update as per https://github.com/CodeYourFuture/Mo…
DamianDL Apr 15, 2026
0d32deb
Refactored code to update as per https://github.com/CodeYourFuture/Mo…
DamianDL Apr 15, 2026
41d2fe6
changed the page constraint from maxlength to max so limmiting no. of…
DamianDL Apr 16, 2026
f3c310d
changed the let Library=[] to Const
DamianDL Apr 16, 2026
59f4052
changed the page length from string to number
DamianDL Apr 16, 2026
f1f4ebc
changed use of .innerHTML to textContent
DamianDL Apr 16, 2026
bfb4558
removed unused but ids
DamianDL Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
<!DOCTYPE html>
<html>
<!doctype html>
<html lang="en">
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<title>Book Library</title>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1" />

<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
Expand All @@ -28,19 +26,24 @@ <h1>Library</h1>
</button>

<div id="demo" class="collapse">
// form to add new book
<div class="form-group">
<label for="title">Title:</label>
<label for="title">Title:</label>// input for book title
<input
type="title"
type="text"
class="form-control"
minlength="1"
maxlength="100"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
type="text"
class="form-control"
minlength="1"
maxlength="100"
id="author"
name="author"
required
Expand All @@ -49,6 +52,8 @@ <h1>Library</h1>
<input
type="number"
class="form-control"
min="1"
max="10000"
id="pages"
name="pages"
required
Expand All @@ -65,7 +70,7 @@ <h1>Library</h1>
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
onclick="submit()"
/>
</div>
</div>
Expand Down
98 changes: 51 additions & 47 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,44 +1,54 @@
let myLibrary = [];
const myLibrary = [];

window.addEventListener("load", function (e) {
window.addEventListener("load", function () {
populateStorage();
render();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
const book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true);
const book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
127,
true
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");
const titleInput = document.getElementById("title");
const authorInput = document.getElementById("author");
const pagesInput = document.getElementById("pages");
const checkInput = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
alert("Please fill all fields!");
const title = titleInput.value.trim();
const author = authorInput.value.trim();
const pages = pagesInput.valueAsNumber;

if (!title) {
alert("Please enter a valid title.");
return false;
}

if (!author) {
alert("Please enter a valid author.");
return false;
}

if (!Number.isInteger(pages) || pages <= 0) {
alert("Please enter a valid page number.");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
titleInput.value = title;
authorInput.value = author;
Comment on lines +48 to +49
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why update the input field with the trimmed values? Why not do the same for "pages")?

Copy link
Copy Markdown
Author

@DamianDL DamianDL Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated when changed page length to number

let book = new Book(title, author, pages, checkInput.checked);
myLibrary.push(book);
render();
}
}
Expand All @@ -51,36 +61,30 @@ function Book(title, author, pages, check) {
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
const table = document.getElementById("display");
const rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
for (let n = rowsNumber - 1; n > 0; n--) {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
const length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
const row = table.insertRow(1);
const titleCell = row.insertCell(0);
const authorCell = row.insertCell(1);
const pagesCell = row.insertCell(2);
const wasReadCell = row.insertCell(3);
const deleteCell = row.insertCell(4);
titleCell.textContent = myLibrary[i].title;
authorCell.textContent = myLibrary[i].author;
pagesCell.textContent = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
const changeBut = document.createElement("button");
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
const readStatus = myLibrary[i].check == true ? "Yes" : "No";
changeBut.innerText = readStatus;

changeBut.addEventListener("click", function () {
Expand All @@ -89,14 +93,14 @@ function render() {
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
const deleteBut = document.createElement("button");
deleteCell.appendChild(deleteBut);
deleteBut.className = "btn btn-warning";
deleteBut.textContent = "Delete";
deleteBut.addEventListener("click", function () {
const deletedTitle = myLibrary[i].title;
myLibrary.splice(i, 1);
alert(`You've deleted title: ${deletedTitle}`);
render();
});
}
Expand Down