Birmingham | 26-ITP-Jan | Tasleem Adedokun | Sprint 2 | Book Library#428
Open
tasleemadedokun wants to merge 15 commits intoCodeYourFuture:mainfrom
Open
Birmingham | 26-ITP-Jan | Tasleem Adedokun | Sprint 2 | Book Library#428tasleemadedokun wants to merge 15 commits intoCodeYourFuture:mainfrom
tasleemadedokun wants to merge 15 commits intoCodeYourFuture:mainfrom
Conversation
… of syntax error.
…function addbook too.
tasleemadedokun
added
📅 Sprint 2
cjyuan
reviewed
Apr 16, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
cjyuan
added
Reviewed
…html validation with required, pattern and min, also load script with type module.
tasleemadedokun
added
Needs Review
Author
Hi, I have updated it. Thanks |
cjyuan
reviewed
Apr 16, 2026
| const authorValue = authorInput.value.trim(); | ||
| const pagesValue = Number(pagesInput.value); | ||
|
|
||
| if (!titleValue || !authorValue || pagesValue <= 0) { |
Comment on lines
+56
to
+66
| const table = document.getElementById("display"); | ||
|
|
||
| table.innerHTML = ` | ||
| <tr> | ||
| <th>Title</th> | ||
| <th>Author</th> | ||
| <th>Pages</th> | ||
| <th>Read</th> | ||
| <th>Delete</th> | ||
| </tr> | ||
| `; |
Contributor
There was a problem hiding this comment.
You could also just clear <tbody>.
Author
There was a problem hiding this comment.
Hopefully, I have addressed all once and for all.
Thanks.
cjyuan
added
Reviewed
tasleemadedokun
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Brief:
I have made several commits and fixed the bugs to the best of my ability.