Skip to content

GLASGOW | 26-ITP-Jan | Prakash Dcosta | Sprint 2 | Book Library#431

Open
dcostaprakash wants to merge 4 commits intoCodeYourFuture:mainfrom
dcostaprakash:BookLibrary
Open

GLASGOW | 26-ITP-Jan | Prakash Dcosta | Sprint 2 | Book Library#431
dcostaprakash wants to merge 4 commits intoCodeYourFuture:mainfrom
dcostaprakash:BookLibrary

Conversation

@dcostaprakash
Copy link
Copy Markdown

@dcostaprakash dcostaprakash commented Apr 13, 2026 •
edited
Loading

Self checklist

  • [X} I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [X} My changes meet the requirements of the task
  • [X} I have tested my changes
  • [X} My changes follow the style guide

Changelist

Debugging of the code for the 5 listed issues in the readme as well as removed duplicate rendering

@github-actions

This comment has been minimized.

Sign in to view
@dcostaprakash dcostaprakash added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 15, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 15, 2026
@github-actions

This comment has been minimized.

Sign in to view
@dcostaprakash dcostaprakash added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 15, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 15, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@dcostaprakash dcostaprakash added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 15, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 15, 2026
@github-actions

This comment has been minimized.

Sign in to view
2 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Apr 15, 2026

Can you edit your PR description to make it look like this:

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Debugging of the code for the 5 listed issues in the readme as well as removed duplicate rendering

@dcostaprakash dcostaprakash added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Flows The name of the module. labels Apr 15, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 15, 2026
@github-actions

This comment has been minimized.

Sign in to view
@dcostaprakash dcostaprakash added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 15, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 15, 2026
@dcostaprakash dcostaprakash added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 15, 2026
cjyuan
cjyuan reviewed Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Module-Data-Flows The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dcostaprakash @cjyuan