Sheffield | 26-ITP-Jan | Mahmoud Shaabo | Sprint 2 | Book Library#450
Open
mahmoudshaabo1984 wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
Sheffield | 26-ITP-Jan | Mahmoud Shaabo | Sprint 2 | Book Library#450mahmoudshaabo1984 wants to merge 1 commit intoCodeYourFuture:mainfrom
mahmoudshaabo1984 wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Author
|
Hi @cifarquhar — PR #450 is ready for review. I have fixed all 5 bugs listed in the readme.md file. The app now loads correctly, books can be added and deleted, and the read status toggles as expected. Please let me know if anything needs to be changed. Thank you! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What bugs did I fix?
Bug 1 - Website loads but doesn't show any books
The
forloop in therenderfunction was missing a closing parenthesis)before the{. This caused a syntax error that stopped all JavaScript from running.Bug 2 - Error in console when you try to add a book
The
submitfunction was callinglibrary.push(book)but the array is namedmyLibrary. Fixed by using the correct variable name. Also added validation for the author field.Bug 3 - It uses the title name as the author name
In the
submitfunction,title.valuewas used twice. The second argument should beauthor.value.Bug 4 - Delete button is broken
The delete button variable was created as
delButtonbut then referenced asdelButthree times. Also the event name was"clicks"instead of"click". Fixed both issues.Bug 5 - Read status saves the wrong answer
The
ifcondition was inverted.check == falsewas showing "Yes". Fixed socheck == truecorrectly shows "Yes".How to test
index.htmlin the browserHi @cifarquhar — I have fixed all 5 bugs listed in the readme. Please let me know if you have any feedback. Thank you!