Skip to content

Sheffield | 26-ITP-Jan | Mona- Eltantawy | Sprint 3| Sprint3 /Quote generator #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mona-Eltantawy wants to merge 5 commits into
base: main
Choose a base branch
from
+101 −11
Open

Sheffield | 26-ITP-Jan | Mona- Eltantawy | Sprint 3| Sprint3 /Quote generator #1153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9f9b2b0
updated the title and h1 elements.
Mona-Eltantawy Mar 30, 2026
ca4da9b
I wrote 3 variables to define the quote, auother, and neq-quote.
Mona-Eltantawy Mar 31, 2026
942eaa2
I wrote a CSS file for the html file.
Mona-Eltantawy Mar 31, 2026
477fd88
Re-edited the HTML file and formatted it.
Mona-Eltantawy Mar 31, 2026
195d942
fixed the function
Mona-Eltantawy Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions Sprint-3/quote-generator/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
<!DOCTYPE html>
<!doctype html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Title here</title>
<title>Quote generator app</title>
<script defer src="quotes.js"></script>
<link rel="stylesheet" href="style.css" />
</head>
<body>
<h1>hello there</h1>
<p id="quote"></p>
<p id="author"></p>
<button type="button" id="new-quote">New quote</button>
<div class="container">
<p id="quote"></p>
<p id="author"></p>
<button type="button" id="new-quote">New quote</button>
</div>
</body>
</html>
30 changes: 26 additions & 4 deletions Sprint-3/quote-generator/quotes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,17 @@
// Examples of use
// ---------------
// pickFromArray(['a','b','c','d']) // maybe returns 'c'
// DOM elements
const quote = document.querySelector("#quote");
const author = document.querySelector("#author");
const newquote = document.querySelector("#new-quote");
Comment on lines +18 to +20
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make variable names (for storing DOM objects) more meaningful, a better practice is to add a suffix to the variable names. For examples, quoteEl, authorEl, newQuoteButton.


// You don't need to change this function
function pickFromArray(choices) {
return choices[Math.floor(Math.random() * choices.length)];
// utility function (given)
function pickFromArray(quotes) {
return quotes[Math.floor(Math.random() * quotes.length)];
}


// A list of quotes you can use in your app.
// DO NOT modify this array, otherwise the tests may break!
const quotes = [
Expand Down Expand Up @@ -490,4 +495,21 @@ const quotes = [
},
];

// call pickFromArray with the quotes array to check you get a random quote


function showRandomQuote() {
const randomQuote = pickFromArray(quotes);
quote.textContent = randomQuote.quote;
author.textContent = randomQuote.author;
}

function setup() {
showRandomQuote();

quote.addEventListener("click", showRandomQuote);
author.addEventListener("click", showRandomQuote);
newquote.addEventListener("click", showRandomQuote);
Comment on lines +509 to +511
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why make also the quote and author paragraph elements clickable?

}


window.addEventListener("load", setup);
68 changes: 67 additions & 1 deletion Sprint-3/quote-generator/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,67 @@
/** Write your CSS in here **/
* {
padding: 0;
margin: 0;
box-sizing: border-box;
}
body {
background-color: orange;
display: flex;
justify-content: center; /* horizontal centering */
align-items: flex-start; /* vertical centering */
height: 100vh; /* full viewport height */
font-family: Georgia, "Times New Roman", Times, serif;
}

.container {
background-color: white;
width: 70%;
max-width: 650px;
padding: 60px 80px;
border-radius: 8px;
text-align: center; /* centers text inside */
margin: 20% 20%;
display: block;
}

#quote {
font-size: 28px;
color: #f59e0b;
line-height: 1.5;
position: relative;
margin-bottom: 30px;
}
#quote::before {
content: "“";
font-size: 80px;
position: absolute;
left: -40px;
top: -20px;
color: #f59e0b;
}
#author {
display: block;
text-align: right;
font-size: 16px;
color: #f59e0b;
margin-bottom: 20px;
}
#author::before {
content: "~ ";
font-size: 20px;
color: #f59e0b;
}
#new-quote {
align-items: right;
text-align: right;
background-color: #f59e0b;
color: white;
border: none;
padding: 10px 20px;
cursor: pointer;
font-size: 14px;
border-radius: 2px;
display: block;
}
#new-quote :hover {
opacity: 0.9;
}
Loading