Glasgow | 26-ITP-Jan| Martin McLean |Sprint 1| coursework

[mjm-git185]

Changelist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide
my coursework

[JaypeeLan]

This works, but there can be some improvements.
Check that elements is an array before calling .filter(), and do an early return if it is empty.
Sorting the entire array is unnecessary if you only need the maximum value.
Consider using Number.isFinite() to ensure only valid numbers are included, so no need for typeof element === "number"

[mjm-git185]

hi I've been working on this but i'm having some trouble with the number.isFinite would you be free at some point tomorrow to go over it please

[JaypeeLan]

You could book a pair programming session.
Before then, try to read this:
https://www.w3schools.com/jsref/jsref_isfinite_number.asp

You just need to replace that check, but you need to know why you are doing it.

[mjm-git185]

Hi sorry i didn't get to you sooner i had some blockers to deal with

[mjm-git185]

Was there any other changed needed

[mjm-git185]

hi JaypeeLan is there anything else that i need to do for this PR

[JaypeeLan]

hi JaypeeLan is there anything else that i need to do for this PR

This branch has conflicts that must be resolved

[mjm-git185]

i think thats it

[mjm-git185]

Thank you