Skip to content

Sheffield | 26-ITP-Jan | Mahammad Osman | Sprint 2 | Form-Controls #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Darkidd77 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Sheffield | 26-ITP-Jan | Mahammad Osman | Sprint 2 | Form-Controls #1106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
af0b1a3
Update form structure and author name in index.html
Darkidd77 Jan 31, 2026
d95c476
Refactor form structure and update author name in index.html
Darkidd77 Jan 31, 2026
119194f
Add fruit selection fieldset to form in index.html
Darkidd77 Jan 31, 2026
091ea56
Refactor form structure to include personal information fields and up…
Darkidd77 Feb 1, 2026
c6f7b8d
Update form structure: enhance personal information fields and improv…
Darkidd77 Feb 1, 2026
e8be45a
Update README.md: mark objectives and criteria as completed
Darkidd77 Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions Form-Controls/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@

<!--{{<objectives>}}>-->

- [ ] Interpret requirements and check against a list of criteria
- [ ] Write a valid form
- [ ] Test with Devtools
- [ ] Refactor using Devtools
- [x] Interpret requirements and check against a list of criteria
- [x] Write a valid form
- [x] Test with Devtools
- [x] Refactor using Devtools
<!--{{<objectives>}}>-->

## Task
Expand All @@ -30,18 +30,18 @@ Do not write a form action for this project.

Let's write out our testable criteria. Check each one off as you complete it.

- [ ] I have used HTML only.
- [x] I have used HTML only.
- [x] I have not used any CSS or JavaScript.

### HTML

- [ ] My form is semantic html.
- [ ] All inputs have associated labels.
- [ ] My Lighthouse Accessibility score is 100.
- [ ] I require a valid name. I have defined a valid name as a text string of two characters or more.
- [ ] I require a valid email.
- [ ] I require one colour from a defined set of 3 colours.
- [ ] I require one size from a defined set of 6 sizes.
- [x] My form is semantic html.
- [x] All inputs have associated labels.
- [x] My Lighthouse Accessibility score is 100.
- [x] I require a valid name. I have defined a valid name as a text string of two characters or more.
- [x] I require a valid email.
- [x] I require one colour from a defined set of 3 colours.
- [x] I require one size from a defined set of 6 sizes.

## Resources

Expand Down
40 changes: 39 additions & 1 deletion Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,52 @@ <h1>Product Pick</h1>
<main>
<form>
<!-- write your html here-->
<fieldset>
<legend>Personal Information</legend>
<label for="name">Name:</label>
<input type="text" id="name" name="name" required minlength="2"/><br /><br />
Copy link
Contributor

@cjyuan cjyuan Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently a user can enter a name consisting of only space characters (e.g., " "). Can you enforce a stricter validation rule using the pattern attribute to disallow any name that contains only space characters?

<label for="email">Email:</label>
<input type="email" id="email" name="email" required /><br /><br />
</fieldset>
<fieldset>
<legend>Product Details</legend>
<p>Colour:</p>
<label for="red">
<input type="radio" id="red" name="Colour" value="Red" required/>
Red
</label>
<br><br>
<label for="blue">
<input type="radio" id="blue" name="Colour" value="Blue" />
Blue
</label>
<br><br>
<label for="green">
<input type="radio" id="green" name="Colour" value="Green" />
Green
</label>
<br><br>
<label for="size">Size:</label>
<select id="size" name="size" required>
<option value="">--Please choose an option--</option>
<option value="xs">XS</option>
<option value="s">S</option>
<option value="m">M</option>
<option value="l">L</option>
<option value="xl">XL</option>
<option value="xxl">XXL</option>
</select><br /><br />
</fieldset>
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<br><br>
<button type="submit">Submit Order</button>
</form>
</main>
<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
<h2>By Mahammad Osman</h2>
</footer>
</body>
</html>
Loading