Skip to content

Cape Town | ITP-JAN-26 | Shannon Davids | Sprint 1| Wireframe#1114

Open
Shannon-Davids wants to merge 3 commits intoCodeYourFuture:mainfrom
Shannon-Davids:feature/Wireframe
Open

Cape Town | ITP-JAN-26 | Shannon Davids | Sprint 1| Wireframe#1114
Shannon-Davids wants to merge 3 commits intoCodeYourFuture:mainfrom
Shannon-Davids:feature/Wireframe

Conversation

@Shannon-Davids
Copy link

@Shannon-Davids Shannon-Davids commented Feb 1, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have made the relevant changes as per the requirements.

Questions

No questions

@netlify
Copy link

netlify bot commented Feb 1, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit d294893
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6984c54b18f08a0008a98373
😎 Deploy Preview https://deploy-preview-1114--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 96 (🔴 down 4 from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Shannon-Davids Shannon-Davids added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 1, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 1, 2026
@github-actions

This comment has been minimized.

@Shannon-Davids Shannon-Davids added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 3, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 3, 2026
@Shannon-Davids Shannon-Davids added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 3, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 3, 2026
@Shannon-Davids Shannon-Davids added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 3, 2026
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is free of syntax error and well formatted. Well done!

There are some typos in the PR description and in index.html. Can you use an AI tool to locate and fix these typos?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 5, 2026
@Shannon-Davids Shannon-Davids added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 5, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 5, 2026

Changes look good.

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

  • Reply to their feedback.
    • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
      • You may find the suggestions in this PR Guide useful.
    • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
  • Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)
    • Without this label, the reviewer would not know if your changes is ready to be reviewed.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants