NW | 25-ITP-Sep | TzeMing Ho | Sprint 2 | coursework/sprint-2#707
Closed
TzeMingHo wants to merge 16 commits intoCodeYourFuture:mainfrom
Closed
NW | 25-ITP-Sep | TzeMing Ho | Sprint 2 | coursework/sprint-2#707TzeMingHo wants to merge 16 commits intoCodeYourFuture:mainfrom
TzeMingHo wants to merge 16 commits intoCodeYourFuture:mainfrom
Conversation
…ixed the conflict with a new variable name
…wer case to upper case and replace all space with underline
…toPounds with input condition checks
TzeMingHo
added
📅 Sprint 2
TzeMingHo
added
Needs Review
CameronDowner
added
Review in progress
CameronDowner
left a comment
CameronDowner
left a comment
There was a problem hiding this comment.
Looking really good - one small question, but will mark as complete 🙂
Comment on lines
+25
to
+28
| function capitalise(str) { | ||
| let capitalisedStr = `${str[0].toUpperCase()}${str.slice(1)}`; | ||
| return capitalisedStr; | ||
| } |
There was a problem hiding this comment.
This works as expected - but do we need a variable here?
Author
There was a problem hiding this comment.
No. We could simply return ${str[0].toUpperCase()}${str.slice(1)}
The variable is not necessarily needed.
CameronDowner
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have attempted to resolve the errors and created functions and tests for the exercises.