NW | 25-ITP-Sep | TzeMing Ho | Sprint 3 | coursework/sprint-3-practice-tdd

[TzeMingHo]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

In the exercises, I wrote tests first, followed by writing functions to fulfill them. Some edge cases were also attempted to be implemented in the tests.

[jenny-alexander]

Great job @TzeMingHo following the principles of TDD. I added a few comments that wll help you write more reliable code.

[jenny-alexander]

It might have been a leftover from debugging, but console logs should be removed before submitting your PR.

[jenny-alexander]

You have written some good tests cases that cover the main cases. However, can you think of some edge cases that should be tested?

• what if str is not a string (i.e. a number)
• what if count is not a number (i.e. "2")
• what if string is empty or null, what should it return?

[jenny-alexander]

@TzeMingHo For this exercise, it says:
"Given a target string str and a positive integer count,"

This means that a number, boolean, null (basically anything not a string), should be considered invalid input.
Converting a non-string to a string would be considered out of scope for this exercise :)
The count should be a positive integer (1,2,3,4,5, etc) and can't have a decimal.

[jenny-alexander]

Your test case covers the most basic cases - but can you think of some edge cases you should write tests for?

• what is count is 2.5?
• what if the count is null or undefined
• what if the string is an array or an object instead of a string?

Writing tests to cover edge cases will protect your implementation from unexpected situations and make your code more robust.

[jenny-alexander]

Maybe a typo in your test assertion here (should be a 1 instead of 0)?

[jenny-alexander]

Maybe a typo in your test assertion here (should be a 1 instead of 0)?

[jenny-alexander]

@TzeMingHo For this exercise, it says:
"Given a target string str and a positive integer count,"

This means that a number, boolean, null (basically anything not a string), should be considered invalid input.
Converting a non-string to a string would be considered out of scope for this exercise :)
The count should be a positive integer (1,2,3,4,5, etc) and can't have a decimal.

[jenny-alexander]

Your test cases are very thorough now. Great job 😃

[TzeMingHo]

Thank you, Jenny.