West Midlands | ITP September 2025 | Jonathan Boahene | Sprint 2 | Module Structuring and Testing Data#825
Closed
Abayie wants to merge 15 commits intoCodeYourFuture:mainfrom
Closed
West Midlands | ITP September 2025 | Jonathan Boahene | Sprint 2 | Module Structuring and Testing Data#825Abayie wants to merge 15 commits intoCodeYourFuture:mainfrom
Abayie wants to merge 15 commits intoCodeYourFuture:mainfrom
Conversation
jaymes15
added
📅 Sprint 2
jaymes15
reviewed
Nov 23, 2025
|
|
||
| // You should call this function a number of times to check it works for different inputs | ||
|
|
||
| function toPounds(penceString) { |
jaymes15
reviewed
Nov 23, 2025
| function toPounds(penceString) { | ||
| // Remove trailing 'p' and pad with zeros to ensure at least 3 digits | ||
| const pence = penceString | ||
| .substring(0, penceString.length - 1) |
There was a problem hiding this comment.
This is clever and handles edge cases very well.
jaymes15
reviewed
Nov 23, 2025
| const pounds = pence.substring(0, pence.length - 2); | ||
| const pencePart = pence.substring(pence.length - 2).padEnd(2, "0"); | ||
| // Return formatted string | ||
| return `£${pounds}.${pencePart}`; |
There was a problem hiding this comment.
💡 Nice that you included the £ symbol directly.
jaymes15
reviewed
Nov 23, 2025
| // `current output: ${currentOutput2}, target output: ${targetOutput2}` | ||
| // ); | ||
|
|
||
| function formatAs12HourClock(time) { |
jaymes15
added
Complete
This was referenced Nov 24, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
In this pull request I have added improved solutions and comprehensive tests for Sprint 2 of Module-Structuring-and-Testing-Data.
I refactored functions to handle edge cases and ensure correct formatting, such as converting 24-hour time strings to 12-hour clock format with am/pm.
The code now includes robust test cases for different input scenarios, including midnight, noon, single-digit hours, and times close to midnight and noon.
These changes enhance reliability and maintainability, making the code easier to understand and verify for a wide range of data inputs.
Questions
No questions at this point