Birmingham | 25-ITP-Sept | Khor Biel | Sprint 3 | coursework/sprint-3-implement-and-rewrite by wankoak · Pull Request #834 · CodeYourFuture/Module-Structuring-and-Testing-Data

wankoak · 2025-11-01T15:44:14Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Fixed some errors

… functions

github-actions · 2025-11-01T15:44:26Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-01T15:44:37Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-01T15:44:37Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-01T15:44:43Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-01T15:44:47Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-01T15:45:00Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-01T15:46:11Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

wilsonadenuga

Good job with this PR, address the comments and you are good to go

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

…ithub.com/wankoak/Module-Structuring-and-Testing-Data into coursework/sprint-3-implement-and-rewrite

wankoak · 2025-11-04T09:44:26Z

@wilsonadenuga all good now

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

wankoak added 4 commits October 23, 2025 10:16

Added Jest test files for angle type, proper fraction, and card value…

3934b5d

… functions

Made small test with jest changes

ced98d6

Fixed errors

be08b79

Fixed errors

6450496

wankoak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 1, 2025

Merge branch 'main' into coursework/sprint-3-implement-and-rewrite

757bbba

wankoak mentioned this pull request Nov 1, 2025

25-ITP-Sept | Structuring and testing data | Khor biel wankoak/My-Coursework-Planner#60

Open

wilsonadenuga added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 1, 2025

wilsonadenuga reviewed Nov 4, 2025

View reviewed changes

wilsonadenuga added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 4, 2025

wankoak added 2 commits November 4, 2025 09:34

Fixed errors

c48508e

Merge branch 'coursework/sprint-3-implement-and-rewrite' of https://g…

fd03be2

…ithub.com/wankoak/Module-Structuring-and-Testing-Data into coursework/sprint-3-implement-and-rewrite

wankoak added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 4, 2025

Added test cases with decimal

a36eb22

wankoak added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 5, 2025

Removed a typo

d5c9c23

wilsonadenuga added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 5, 2025

wankoak added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 5, 2025

wilsonadenuga reviewed Nov 5, 2025

View reviewed changes

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js Show resolved Hide resolved

wilsonadenuga added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 5, 2025

Fix: handle invalid angles below 0 or above 360 in getAngleType

9f62701

wankoak added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 5, 2025

wilsonadenuga reviewed Nov 5, 2025

View reviewed changes

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js Outdated Show resolved Hide resolved

wilsonadenuga added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 5, 2025

Refactored separate invalid angle tests

09965f1

wankoak added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 5, 2025

wilsonadenuga reviewed Nov 5, 2025

View reviewed changes

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js Outdated Show resolved Hide resolved

wilsonadenuga added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 5, 2025

Fixed

a25cc1b

wilsonadenuga reviewed Nov 5, 2025

View reviewed changes

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js Outdated Show resolved Hide resolved

Fixed errors

a7b091e

wankoak added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 5, 2025

wilsonadenuga added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 5, 2025

illicitonion closed this Jan 7, 2026

Uh oh!

Conversation

wankoak commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelist

Uh oh!

github-actions bot commented Nov 1, 2025

Uh oh!

github-actions bot commented Nov 1, 2025

Uh oh!

github-actions bot commented Nov 1, 2025

Uh oh!

github-actions bot commented Nov 1, 2025

Uh oh!

github-actions bot commented Nov 1, 2025

Uh oh!

github-actions bot commented Nov 1, 2025

Uh oh!

github-actions bot commented Nov 1, 2025

Uh oh!

wilsonadenuga left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wankoak commented Nov 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wankoak commented Nov 1, 2025 •

edited

Loading