London | 25-ITP-Sep | Payman Issa Baiglu | Sprint 2 | Coursework/sprint 2 by PaymanIB · Pull Request #838 · CodeYourFuture/Module-Structuring-and-Testing-Data

PaymanIB · 2025-11-02T16:10:17Z

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

in this PR: Sprint 2 Coursework completed. errors fixed and questions answered

… correct convertToPercentage function implementation

…mple

… digit

…_CASE

…formatting

jennethydyrova

Hi @PaymanIB! Very good work on these exercises! I left several comments you need to address. You also have some extra file in the commit you pushed, can you please remove it?

jennethydyrova · 2025-11-03T15:12:23Z

Sprint-2/1-key-errors/0.js

 // Predict and explain first...
 //  =============> write your prediction here
-
+// it gives us an error.


You should try to be more specific, what type of error?

jennethydyrova · 2025-11-03T15:14:55Z

Sprint-2/1-key-errors/0.js

+  let str1 = `${str[0].toUpperCase()}${str.slice(1)}`;
+  return str1;


Why do you use let here? Also, can you think of a way to simplify these two lines?

jennethydyrova · 2025-11-03T15:22:21Z

Sprint-2/1-key-errors/1.js

+// Why will an error occur when this program runs? yes
 // =============> write your prediction here
+// decimalNumber is declared before and can not be declared again.
+// console.log(decimalNumber) should be console.log(convertToPercentage)


This is correct but why is that a case? Why we can't do console.log(decimalNumber)?

I think the only comment left unaddressed is this one @PaymanIB

looks good overall @PaymanIB, I'd just suggest cleaning up code by removing unused comments.

jennethydyrova · 2025-11-03T15:23:40Z

Sprint-2/1-key-errors/1.js

 // Finally, correct the code to fix the problem
 // =============> write your new code here
+function convertToPercentage(decimalNumber) {
+  //const decimalNumber = 0.5;


Let's keep the code clean and remove all scratch work and commented out code (within functions you wrote).

jennethydyrova · 2025-11-03T15:24:02Z

Sprint-2/1-key-errors/1.js

+  const percentage = `${decimalNumber * 100}%`;
+
+  return percentage;


Can you think of a way to simplify this?

Sprint-2/2-mandatory-debug/1.js

jennethydyrova · 2025-11-03T15:30:18Z

Sprint-2/2-mandatory-debug/2.js


 // Predict the output of the following code:
 // =============> Write your prediction here
+// the result will be 3 times 


What does it mean?

jennethydyrova · 2025-11-03T16:09:08Z

Sprint-2/3-mandatory-implement/3-to-pounds.js

+const penceStringWithoutTrailingP = penceString.substring(0 , penceString.length - 1);
+const paddedPenceNumberString = penceStringWithoutTrailingP.padStart(3, "0");
+const pounds = paddedPenceNumberString.substring(0,paddedPenceNumberString.length - 2);
+const pence = paddedPenceNumberString.substring(paddedPenceNumberString.length - 2).padEnd(2, "0");
+
+return `£${pounds}.${pence}`;


Do you have prettier installed? If no, I would recommend installing it and formatting your code. This is not a correct indentation, makes your code look messier

jennethydyrova · 2025-11-03T16:10:30Z

Sprint-2/4-mandatory-interpret/time-format.js

+  const totalMinutes = (seconds - remainingSeconds) / 60; //1
+  const remainingMinutes = totalMinutes % 60; //1


Do you need these comments here?

jennethydyrova · 2025-11-05T16:17:15Z

Hi @PaymanIB! Do you want to do another round of review? If yes, please change label to needs review and request review.

…ntation

…age function

…tion

…function

… code

PaymanIB · 2025-11-09T14:54:14Z

Hi @jennethydyrova, Sorry for the late reply and many thanks for your help and support. Unfortunately, I had a very rough week last week and couldn't focus on finishing this task. I would appreciate if you can review the changes I made based on your first review. Thanks and regards.

jennethydyrova · 2025-11-10T19:42:10Z

Hi @PaymanIB! The changes look good but can you please remove Sprint-2/2-mandatory-debug/new.js file from this PR?

PaymanIB · 2025-11-10T20:47:21Z

Hi @jennethydyrova, I totally forgot that part. Thanks for reminding me. that file is deleted. Would you please check again.

PaymanIB · 2025-11-22T15:05:03Z

@wahibkamran Thank you for reviewing my PR. If it is OK. can you please change the label to complete as well.

jennethydyrova · 2025-11-22T16:58:44Z

@PaymanIB set to complete

PaymanIB · 2025-11-23T14:59:13Z

Great! Thank you!

Payman IB added 12 commits November 1, 2025 11:32

1-key-errors,0.js, completed

2c6aae7

Fix variable shadowing in capitalise function and update console log;…

876bf7b

… correct convertToPercentage function implementation

Fix function definition and error explanations in square function exa…

058c055

…mple

Fix multiply function to return value and update

c8cebbb

Fix sum function to return correct value and update console log

a5bdca3

Fix getLastDigit function to accept parameter and return correct last…

7ea670b

… digit

Implement BMI calculation function and log result

f5b79bf

Fix console log statement formatting in BMI calculation

b760859

Implement toUpperSnakeCase function to convert strings to UPPER_SNAKE…

1f37466

…_CASE

Implement toPounds function to convert pence to pounds and log results

e943a03

Refactor comments and formatting in time-format.js for clarity

5f29b84

Refactor formatAs12HourClock function to improve time validation and …

8ecd330

…formatting

PaymanIB added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 2, 2025

jennethydyrova added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 3, 2025

jennethydyrova suggested changes Nov 3, 2025

View reviewed changes

jennethydyrova added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 3, 2025

Payman IB added 2 commits November 3, 2025 18:54

Update comment to clarify syntax error in capitalise function

0e37a64

updated the answer on line 4.

cd942b8

Payman IB added 8 commits November 9, 2025 14:01

Remove redundant comments and clarify the capitalise function impleme…

906778c

…ntation

Fix indentation in commented-out code for clarity in convertToPercent…

ed909e1

…age function

Update comment to clarify explanation of return statement in sum func…

d486397

…tion

Remove redundant declaration of decimalNumber in convertToPercentage …

6eb8b88

…function

Refactor convertToPercentage function to return percentage directly

62492e1

Fix prediction comment in 2.js to accurately reflect expected output

25347a2

Refactor toPounds function for improved readability and consistency

ba8d606

Remove unnecessary comments in formatTimeDisplay function for cleaner…

b185d08

… code

PaymanIB added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 9, 2025

jennethydyrova added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 10, 2025

Delete Sprint-2/2-mandatory-debug/new.js

c335f18

PaymanIB added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 10, 2025

jennethydyrova added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 10, 2025

PaymanIB added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 10, 2025

wahibkamran approved these changes Nov 22, 2025

View reviewed changes

wahibkamran added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 22, 2025

jennethydyrova added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 22, 2025

illicitonion closed this Jan 7, 2026

		let str1 = `${str[0].toUpperCase()}${str.slice(1)}`;
		return str1;

		const percentage = `${decimalNumber * 100}%`;

		return percentage;

		const totalMinutes = (seconds - remainingSeconds) / 60; //1
		const remainingMinutes = totalMinutes % 60; //1

Uh oh!

Conversation

PaymanIB commented Nov 2, 2025

Uh oh!

jennethydyrova left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jennethydyrova commented Nov 5, 2025

Uh oh!

PaymanIB commented Nov 9, 2025

Uh oh!

jennethydyrova commented Nov 10, 2025

Uh oh!

PaymanIB commented Nov 10, 2025

Uh oh!

PaymanIB commented Nov 22, 2025

Uh oh!

jennethydyrova commented Nov 22, 2025

Uh oh!

PaymanIB commented Nov 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants