Manchester |25-ITP-Sep|Mahtem T. Mengstu |Sprint 3|coursework/sprint-3-implement-and-rewrite#851
Closed
Mahtem wants to merge 19 commits intoCodeYourFuture:mainfrom
Closed
Conversation
…ssary functions added
…ote tests in jest
Mahtem
added
📅 Sprint 3
Mahtem
changed the title
cjyuan
reviewed
Nov 8, 2025
Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
Outdated
Show resolved
Hide resolved
Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
Outdated
Show resolved
Hide resolved
Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js
Outdated
Show resolved
Hide resolved
Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
Outdated
Show resolved
Hide resolved
Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
Outdated
Show resolved
Hide resolved
Comment on lines
+22
to
+25
| // test("should return 11 for Ace of Spades", () => { | ||
| // const aceofSpades = getCardValue("A♠"); | ||
| // expect(aceofSpades).toEqual(11); | ||
| // }); |
Contributor
There was a problem hiding this comment.
-
We could remove code that's no longer needed (to keep the code clean).
-
The function is not expected to validate the suit character. On line 5, mentioning the suit character in the test description could mislead the person implementing the function into thinking the function needs also to check the suit character.
Author
There was a problem hiding this comment.
Good, that's right, I have removed misleading description. and changed it.
cjyuan
added
Reviewed
…ndle possible edge cases.
Contributor
|
Can you also address all my inline comments? You can see them on #851 (Sorry, thought you had finished making changes) |
…ement to handle valid numeric literals such as '2.1' and '002'.
…lues such as boundr values 2 and 10 in line 12-17
Author
I have addressed all your inline comments. |
Contributor
|
Changes look good. Well done. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Jest testing was performed.
Questions
Any question will be asked in Slack.